Addressed Pagination and empty Data handling issues in the AWS Systems Manager GetInventory custom connector and AWS-SSM-GetInstancePatches playbook #13392
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 1551180.
Bump solution version to 3.0.2 across templates and documentation. Update playbooks and templates to use the correct 'value' property for inventory entities instead of 'Entities'. Clean up commented code and add improved logging in the GetInventory function. Update deployment and package files to reflect the new version.
v-utpalkumar
changed the title
rahul0216
reviewed
Jan 14, 2026
Collaborator
rahul0216
left a comment
rahul0216
left a comment
There was a problem hiding this comment.
Please address inline comments.
| next_token = req_body.get('NextToken') | ||
| max_results = req_body.get('MaxResults') | ||
|
|
||
| logging.info(f'Parsed Parameters - Filters: {filters}, Aggregators: {aggregators}, ResultAttributes: {result_attributes}, NextToken: {next_token}, MaxResults: {max_results}') |
Collaborator
There was a problem hiding this comment.
Remove NextToken from logging.
|
|
||
| try: | ||
| logging.info('Calling function to get AWS SSM Inventory.') | ||
| logging.info(f'Parameters: {kwargs}') |
Collaborator
There was a problem hiding this comment.
Same here, don't log parameters, as it may contain sensitive data.
| "nextLink": None | ||
| } | ||
| logging.info(f'count: {count}') | ||
| logging.info(f'Response:{response}') |
Collaborator
There was a problem hiding this comment.
Same here these two logging statements are not required or add generic statements.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Required items, please complete
Change(s):
Reason for Change(s):
Version Updated:
Testing Completed: