Conversation
…validation Changed workspace and workspace-location parameters from defaultValue to minLength validation to ensure required values are provided during deployment.
TwistedAlex
approved these changes
Jan 30, 2026
jlheard
previously approved these changes
Jan 30, 2026
Contributor
|
The |
Contributor
|
@prajval-um, the issue with the |
jlheard
approved these changes
Feb 2, 2026
jlheard
requested changes
Feb 2, 2026
Contributor
jlheard
left a comment
jlheard
left a comment
There was a problem hiding this comment.
The KQL validation checks are failing. Please take a look.
jlheard
reviewed
Feb 2, 2026
- Change author from "Microsoft - support@microsoft.com" to "Cisco Duo - support@duosecurity.com" - Add activity logs to solution description alongside existing log types (authentication, administrator, telephony, offline enrollment, Trust Monitor) - Update parser display name from "CiscoDuoSecurity Data Parser" to "Parser for CiscoDuo" - Update parser resource name from "CiscoDuoSecurity Data Parser" to "CiscoDuo" - Fix workspace-location output
jlheard
approved these changes
Feb 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Required items, please complete
Change(s):
locationandworkspace-locationfrom the selected Log Analytics workspace, preventing emptylocationduring Azure portal installation.workspaceandworkspace-location(minLength: 1) to prevent deployments with empty values.3.1.0:_solutionVersionand “template version …” strings)Version)3.1.0entry)Solutions/CiscoDuoSecurity/Package/3.1.0.zipto include updated createUiDefinition.json and mainTemplate.json.Reason for Change(s):
locationparameter (location selection hidden in UI), causing ARM validation failure:The provided value for the template parameter 'location' is not valid. Length of the value should be greater than or equal to '1'.locationis always passed (derived from the selected workspace), aligning portal behavior with expected deployment requirements.Version Updated:
Detections/Analytic Rule templatesYAML (no detection YAML changes).3.1.0.Testing Completed:
az deployment group validateagainst RGexistingciscoduoconnectorusing Solutions/CiscoDuoSecurity/Package/testParameters.json.az deployment group what-ifagainst RGexistingciscoduoconnectorusing the same parameters (after ensuring workspace is onboarded to Sentinel).https://github.com/Azure/Azure-Sentinel/tree/master/Solutions
https://github.com/Azure/Azure-Sentinel/blob/master/Tools/Create-Azure-Sentinel-Solution/V3/README.md
Checked that the validations are passing and have addressed any issues that are present:
az deployment group validate).az deployment group what-if).3.1.0.zipartifact.