Skip to content

Mateoruiz/bugfix/multistream#13589

Open
m-ruiz21 wants to merge 4 commits intoAzure:masterfrom
m-ruiz21:mateoruiz/bugfix/multistream
Open

Mateoruiz/bugfix/multistream#13589
m-ruiz21 wants to merge 4 commits intoAzure:masterfrom
m-ruiz21:mateoruiz/bugfix/multistream

Conversation

@m-ruiz21
Copy link
Contributor

@m-ruiz21 m-ruiz21 commented Feb 6, 2026

This pull request addresses an issue with duplicate collector creation for the Amazon Web Services NetworkFirewall solution and improves handling of dynamic stream names in the connector resources. The changes ensure that only one resource is created when dynamic stream names are used, with conditional logic applied to select the correct destination table. Additionally, the solution version is updated and documentation is improved.

cherry picked from @solhaile 's branch.

Change(s):

  • Improved logic in createCCPConnector.ps1 so that for dynamic stream names, only one resource is created with conditional logic for destination table selection, preventing duplicate collector creation.

  • Added code to build nested conditional logic for the destinationTable property based on stream name mappings, ensuring correct table assignment in ARM templates.

  • Updated ARM template (mainTemplate.json) to use conditional logic for destinationTable selection, replacing multiple connector resource definitions with a single parameterized resource.

  • Updated solution version to 3.0.3 in Solution_AmazonWebServices.json, mainTemplate.json, and package properties to reflect the new release. [1] [2] [3]

  • Added release note for version 3.0.3, documenting the fix for duplicate collectors creation.

  • Clarified connector description in createUiDefinition.json to specify data connector is via Codeless Connector Framework.

    Testing Completed:

    • Manual testing / deployment to portal

    Checked that the validations are passing and have addressed any issues that are present:

    • See guidance below

@m-ruiz21 m-ruiz21 requested review from a team as code owners February 6, 2026 15:11
@jlheard
Copy link
Contributor

jlheard commented Feb 6, 2026

Looks like this fix also need to be applied to other dynamic data connectors that could potentially have the same behavior with a dropdown named streamName / isDynamicStreamName?

Example: https://github.com/Azure/Azure-Sentinel/blob/master/Solutions/VMware%20Carbon%20Black%20Cloud/Package/mainTemplate.json

@v-shukore v-shukore added the Solution Solution specialty review needed label Feb 9, 2026
@m-ruiz21
Copy link
Contributor Author

m-ruiz21 commented Feb 9, 2026

Looks like this fix also need to be applied to other dynamic data connectors that could potentially have the same behavior with a dropdown named streamName / isDynamicStreamName?

Example: https://github.com/Azure/Azure-Sentinel/blob/master/Solutions/VMware%20Carbon%20Black%20Cloud/Package/mainTemplate.json

I was thinking about that too, this only works since they're all identical besides the Queue URL, but there doesn't seem to be anything that exists to account for this. Frankly, I assumed it was default behavior for the connector grid

@jlheard
Copy link
Contributor

jlheard commented Feb 11, 2026

Looks like this fix also need to be applied to other dynamic data connectors that could potentially have the same behavior with a dropdown named streamName / isDynamicStreamName?
Example: https://github.com/Azure/Azure-Sentinel/blob/master/Solutions/VMware%20Carbon%20Black%20Cloud/Package/mainTemplate.json

I was thinking about that too, this only works since they're all identical besides the Queue URL, but there doesn't seem to be anything that exists to account for this. Frankly, I assumed it was default behavior for the connector grid

We can address it later if it comes up

jlheard
jlheard previously approved these changes Feb 11, 2026
@v-maheshbh
Copy link
Contributor

Hi @m-ruiz21

Kindly revert these changes if they are not part of this PR.

image

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

auto-package Solution Solution specialty review needed

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants