feat: introduces spec for typed variables#2129
Closed
ReneHezser wants to merge 2 commits intomainfrom
Closed
Conversation
microsoft-github-policy-service
bot
added
the
Needs: Triage 🔍
Contributor
There was a problem hiding this comment.
My comments from this PR apply here: #2131
Seems you have accidently carried both changes into the other PR.
Contributor
There was a problem hiding this comment.
Quote:
Question: Variables don't need an explicit type and this change would require all modules to be updated. Is there a good reason for this?
Why would we want to do that? You can also explicitely specify the type of every single variable in PowerShell - yet you'd only want to do this for parameters.
Contributor
Author
There was a problem hiding this comment.
Thanks. Fixed that. Long day :-(
|
|
||
| ## ID: BCPNRF23 - Category: Composition - Code Styling - Typed Variables | ||
|
|
||
| A `type` **SHOULD** be defined for every variable and be as precise as possible. |
Contributor
There was a problem hiding this comment.
Just had a chat about that in the Bicep call suggesting to change this to a 'MAY'. Thoughts?
auto-merge was automatically disabled
July 23, 2025 06:21
Pull request was closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview/Summary
In Bicep, variables should have a type.
AB#41075
This PR fixes/adds/changes/removes
Breaking Changes
None
As part of this Pull Request I have
mainbranch