feat: add service group interface for bicep #2338
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
microsoft-github-policy-service
bot
added
the
Needs: Triage 🔍
1 task
Contributor
Author
|
@AlexanderSehr docs PR for Azure/bicep-registry-modules#6013 |
Comment on lines
+5
to
+7
| import { serviceGroupTargetResourceIdsType } from 'br/public:avm/utl/types/avm-common-types:>version<' | ||
| @description('Optional. The resource IDs of the service groups you wish to associate this resource with.') | ||
| param serviceGroupTargetResourceIds serviceGroupTargetResourceIdsType[]? |
Contributor
There was a problem hiding this comment.
Similar to the comment I added to the types PR itself: What speaks against
Suggested change
| import { serviceGroupTargetResourceIdsType } from 'br/public:avm/utl/types/avm-common-types:>version<' | |
| @description('Optional. The resource IDs of the service groups you wish to associate this resource with.') | |
| param serviceGroupTargetResourceIds serviceGroupTargetResourceIdsType[]? | |
| @description('Optional. The resource IDs of the service groups you wish to associate this resource with.') | |
| param serviceGroupTargetResourceIds string[]? |
Contributor
|
In one of them Core-Team calls we agreed not to publish a interface for this, given that no object/array-of-objects must be specified, but simple string/string[] |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview/Summary
Add service group membership interface for bicep as per discussion #2324
Merge with this PR Azure/bicep-registry-modules#6013 at the same time
As part of this Pull Request I have
mainbranch