feat: avmtf v1 #2406
Draft
feat: avmtf v1 #2406
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
microsoft-github-policy-service
bot
added
the
Needs: Triage 🔍
|
Important The "Needs: Triage 🔍" label must be removed once the triage process is complete! Tip For additional guidance on how to triage this issue/PR, see the AVM Issue Triage documentation. |
matt-FFFFFF
commented
Oct 30, 2025
Comment on lines
+23
to
+24
|
|
||
| Authors **MUST** specify the `replace_triggers_refs` argument when using the AzAPI provider. The values should contain the body paths that would cause the resource to be replaced when they change. |
Member
Author
There was a problem hiding this comment.
Mention that name & location already cause a replacement
| ## ID: TFNFR18 - Category: Code Style - Variables with Types | ||
|
|
||
| `type` **MUST** be defined for every `variable`. `type` **SHOULD** be as precise as possible, `any` **MAY** only be defined with adequate reasons. | ||
| `type` **MUST** be defined for every `variable`. `type` **SHOULD** be as precise as possible. Authors **SHOULD NOT** use `any`. |
Member
Author
There was a problem hiding this comment.
Change to MUST NOT use any
| - `network_interface_name` - (Optional) The name of the network interface. One will be generated if not set. | ||
| - `location` - (Optional) The Azure location where the resources will be deployed. Defaults to the location of the resource group. | ||
| - `resource_group_name` - (Optional) The resource group where the resources will be deployed. Defaults to the resource group of the Key Vault. | ||
| - `resource_group_resource_id` - (Optional) The resource group where the resources will be deployed. Defaults to the resource group of the resource. |
Member
Author
There was a problem hiding this comment.
Set to parent_id and update above
matt-FFFFFF
commented
Oct 30, 2025
Member
Author
There was a problem hiding this comment.
Add parent_id rule and remove resource group name
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
wip