Enhance PR approval guidance and module lifecycle documentation #2486
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
matebarabas
added
the
Type: Documentation 📄
microsoft-github-policy-service
bot
added
the
Needs: Triage 🔍
| click D "{{% siteparam base %}}/contributing/terraform/terraform-contribution-flow/#4-run-pre-commit-checks" | ||
| E(5 - Create a pull request to the upstream repository) | ||
| click E "{{% siteparam base %}}/contributing/terraform/terraform-contribution-flow/#5-create-a-pull-request-to-the-upstream-repository" | ||
| F(6 - Get your pull request reviewed & approved) |
Contributor
There was a problem hiding this comment.
Suggested change
| F(6 - Get your pull request reviewed & approved) | |
| F(6 - Get your pull request reviewed, address any comments & have it approved) |
Contributor
Author
There was a problem hiding this comment.
I prefer not to have such long chapter title and so many words in the flow chart. In fact, I shortened it even further, given the whole point here is to get the PR approved - all requirements need to be further detailed in the actual chapter. Therefore, I also added an info-box elaborating on the point you were trying to make (i.e., all outstanding comments need to be addressed and the module owner needs to make sure the publication pipeline succeeds).
| click E "{{% siteparam base %}}/contributing/bicep/bicep-contribution-flow/#5-createupdate-and-run-tests" | ||
| F(6 - Create a pull request to the upstream repository) | ||
| click F "{{% siteparam base %}}/contributing/bicep/bicep-contribution-flow/#6-create-a-pull-request-to-the-public-bicep-registry" | ||
| G(7 - Get your pull request reviewed & approved) |
Contributor
There was a problem hiding this comment.
Suggested change
| G(7 - Get your pull request reviewed & approved) | |
| G(7 - Get your pull request reviewed, address any comments & have it approved) |
Contributor
Author
There was a problem hiding this comment.
See my comment on the same above.
AlexanderSehr
approved these changes
Nov 23, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Improve documentation regarding the PR approval process for module submissions, clarifying requirements for both new modules and updates to existing ones. Add detailed guidance on who can approve PRs based on module ownership. Update flowcharts to reflect these changes.
Includes updates for both our Bicep and Terraform guidance.