Unique ID GitHub Action - parsing failure fix and wording update#492
Merged
aschabus merged 7 commits intoAzure:mainfrom Feb 6, 2025
Merged
Unique ID GitHub Action - parsing failure fix and wording update#492aschabus merged 7 commits intoAzure:mainfrom
aschabus merged 7 commits intoAzure:mainfrom
Conversation
added 7 commits
February 5, 2025 12:38
aschabus
approved these changes
Feb 6, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#491
Root Cause:
I was able to find the source file we are getting from https://www.azadvertizer.net is now large enough that it is being compressed to binary and therefore was failing to be parsed by the JSON parser in bash.
Solution:
Added the --compressed flag to the curl request to handle the compression of the file.
Extra Testing:
Validated the --compressed flag in curl would not throw an error when downloading an uncompressed file so this should not be a breaking change if we start receiving an uncompressed response from azadvertizer.net again.
#477
While in the code I also added the wording improvements to this script to remove the direct references to built-in definitions and to keep the responses more generic / inclusive of the fact that we can also match community policies with this data source.