fix: adding missing spc and itn regions to pdns resolver template#2137
Merged
fix: adding missing spc and itn regions to pdns resolver template#2137
Conversation
7 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR replaces #2134 to enable CI/CD checks with required secrets.
Original PR by @joselcaguilar
This pull request updates the
privateDnsResolver.jsonARM template to improve region support and clean up the template structure. The most significant change is a comprehensive update to the allowed Azure regions for DNS Private Resolver deployments, ensuring better alignment with current Azure regional availability. Minor formatting and structure improvements have also been made for consistency.Azure region support:
allowedValueslist for the region parameter to include a much broader and up-to-date set of Azure regions, removing deprecated or unsupported regions and adding many new ones. This ensures deployments are possible in all currently supported regions.Template structure and formatting:
dependsOnandvariablesfields for better readability and consistency (e.g.,"dependsOn": []instead of an empty array with line breaks, and"variables": {}instead of a multi-line empty object). [1] [2] [3]Overview/Summary
Private DNS Resolver cannot be deployed using the accelerator through the Portal Experience in Spain Central and Italy North regions, this service is already available on those regions.
This PR fixes/adds/changes/removes
Breaking Changes
N/A
Testing Evidence
Only added more regions to
allowedValuesarray, region availability per product is hereTesting URLs
Azure Public
Azure US Gov (Fairfax)
As part of this Pull Request I have
mainbranch/docs/wiki/whats-new.md)