Skip to content

feat: Add custom connection parameter editor service and fix HTTP client auth logic#7308

Closed
Copilot wants to merge 1 commit intomainfrom
copilot/fix-dd6ea8c0-34cb-42fd-83fc-7cd74acb30bc
Closed

feat: Add custom connection parameter editor service and fix HTTP client auth logic#7308
Copilot wants to merge 1 commit intomainfrom
copilot/fix-dd6ea8c0-34cb-42fd-83fc-7cd74acb30bc

Conversation

Copy link
Copy Markdown
Contributor

Copilot AI commented May 23, 2025

Summary

This PR adds a custom connection parameter editor service for agent connections and fixes HTTP client authorization logic for ARM resources in the VSCode Logic Apps extension.

Changes

✨ New Features

Custom Connection Parameter Editor Service

  • Added CustomConnectionParameterEditorService that provides specialized UI handling for agent connection parameters
  • Returns CustomOpenAIConnector component for connectionProviders/agent connector type
  • Integrated into VSCode React app service layer

Enhanced Logger Service

  • Added logErrorWithFormatting method for improved error logging with stack traces and error causes
  • Better debugging capabilities for development and production scenarios

🐛 Bug Fixes

HTTP Client Authorization Logic

  • Fixed POST method authorization to properly handle ARM resource IDs and conditional auth scenarios
  • Changed logic to only include Authorization header when (includeAuth OR isArmId) AND NOT noAuth
  • Maintains backward compatibility while fixing edge cases where auth was incorrectly applied

Designer Edge Visibility

  • Fixed issue with arrow visibility in the designer UI

🧹 Maintenance

Localization Cleanup

  • Removed unused string resource zMKxg9 (regex validation message)

Testing

  • ✅ All VSCode extension unit tests pass (25/25)
  • ✅ HTTP client tests updated and passing (11/11)
  • ✅ Code follows repository standards (eslint + biome)
  • ✅ No breaking changes to existing functionality

Files Changed

Localize/lang/strings.json                                               
apps/vs-code-react/src/app/designer/services/customConnectionParameterEditorService.ts (new)
apps/vs-code-react/src/app/designer/servicesHelper.ts                   
apps/vs-code-react/src/app/services/Logger.ts                           
libs/designer/src/lib/ui/connections/edge.tsx                           
libs/vscode-extension/src/lib/services/__test__/httpClient.spec.ts       
libs/vscode-extension/src/lib/services/httpClient.ts                     

Impact

  • Enhanced VSCode Logic Apps extension with better agent connection parameter handling
  • More reliable HTTP client behavior for ARM resource authentication scenarios
  • Improved error logging and debugging capabilities
  • Cleaner codebase with removal of unused resources

Breaking Changes

None. All changes are backward compatible.

Warning

Firewall rules blocked me from connecting to one or more addresses

I tried to connect to the following addresses, but was blocked by firewall rules:

  • cdn.fwupd.org

If you need me to access, download, or install something from one of these locations, you can either:


💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.

Copilot AI changed the title [WIP] Merge fixCustomParamService branch into main feat: Add custom connection parameter editor service and fix HTTP client auth logic May 23, 2025
Copilot AI requested a review from ccastrotrejo May 23, 2025 21:27
@ccastrotrejo ccastrotrejo marked this pull request as ready for review May 23, 2025 22:25
@ccastrotrejo ccastrotrejo added the risk:low Low risk change with minimal impact label May 23, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

risk:low Low risk change with minimal impact

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants