Fix Custom Parameter Connection and Authorization Logic#7312
Closed
Copilot wants to merge 1 commit intohotfix/v5.94from
Closed
Fix Custom Parameter Connection and Authorization Logic#7312Copilot wants to merge 1 commit intohotfix/v5.94from
Copilot wants to merge 1 commit intohotfix/v5.94from
Conversation
Copilot
AI
changed the title
[WIP] Merge ccastrotrejo/customParamConnectionhotfix into hotfix/v5.94
Fix Custom Parameter Connection and Authorization Logic
May 25, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR merges the changes from
ccastrotrejo/customParamConnectionhotfixbranch tohotfix/v5.94to address issues with custom parameter connections and authorization logic.Changes
CustomConnectionParameterEditorServiceto provide custom editors for connection parameters, specifically for agent connectorsservicesHelper.tsto register and use the new parameter editor service in the designerLogger.tsby addinglogErrorWithFormattingmethod for better error reportinghttpClient.spec.tsto match the new authorization behaviorProblem Solved
The previous implementation was using ARM resource ID checks to determine when to include authorization headers, which was causing issues with custom parameter connections that didn't follow ARM ID patterns but still required auth. This fix makes the authorization logic more flexible by using explicit flags (
includeAuthandnoAuth) to control when authorization headers should be included.The PR also adds support for custom connection parameter editors, which allows special handling of connection parameters for specific connector types like agent connectors.
Testing
The changes have been tested with custom parameter connections to ensure they receive proper authentication headers and the custom parameter editors are correctly registered and used.
💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.