Skip to content

Fix Custom Parameter Connection and Authorization Logic#7312

Closed
Copilot wants to merge 1 commit intohotfix/v5.94from
copilot/fix-12bfdc24-4d37-4a38-b332-9209220b5ab5
Closed

Fix Custom Parameter Connection and Authorization Logic#7312
Copilot wants to merge 1 commit intohotfix/v5.94from
copilot/fix-12bfdc24-4d37-4a38-b332-9209220b5ab5

Conversation

Copy link
Copy Markdown
Contributor

Copilot AI commented May 25, 2025

This PR merges the changes from ccastrotrejo/customParamConnectionhotfix branch to hotfix/v5.94 to address issues with custom parameter connections and authorization logic.

Changes

  • Added CustomConnectionParameterEditorService to provide custom editors for connection parameters, specifically for agent connectors
  • Updated servicesHelper.ts to register and use the new parameter editor service in the designer
  • Enhanced error handling in Logger.ts by adding logErrorWithFormatting method for better error reporting
  • Fixed authorization header logic in HTTP client to properly handle authentication for custom parameter connections
  • Updated related test in httpClient.spec.ts to match the new authorization behavior

Problem Solved

The previous implementation was using ARM resource ID checks to determine when to include authorization headers, which was causing issues with custom parameter connections that didn't follow ARM ID patterns but still required auth. This fix makes the authorization logic more flexible by using explicit flags (includeAuth and noAuth) to control when authorization headers should be included.

The PR also adds support for custom connection parameter editors, which allows special handling of connection parameters for specific connector types like agent connectors.

Testing

The changes have been tested with custom parameter connections to ensure they receive proper authentication headers and the custom parameter editors are correctly registered and used.


💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.

Copilot AI changed the title [WIP] Merge ccastrotrejo/customParamConnectionhotfix into hotfix/v5.94 Fix Custom Parameter Connection and Authorization Logic May 25, 2025
Copilot AI requested a review from ccastrotrejo May 25, 2025 20:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants