-
Notifications
You must be signed in to change notification settings - Fork 96
fix(vscode): Prompt for azure connector details and start design-time host on new projects #8607
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
fix(vscode): Prompt for azure connector details and start design-time host on new projects #8607
Conversation
🤖 AI PR Validation ReportPR Review ResultsThank you for your submission! Here's detailed feedback on your PR title and body compliance:✅ PR Title
✅ Commit Type
✅ Risk Level
|
| Section | Status | Recommendation |
|---|---|---|
| Title | ✅ | No change required |
| Commit Type | ✅ | No change required |
| Risk Level | ✅ | Label matches change |
| What & Why | Add a short note about async behavior/side-effects | |
| Impact of Change | ❌ | Clarify Users/Developers/System impacts |
| Test Plan | ❌ | Add unit/E2E tests or detailed manual test steps + rationale |
| Contributors | Optional: add other contributors if applicable | |
| Screenshots/Videos | Optional: add if UI/UX changed |
Final message
This PR does not pass the PR-body compliance check because the Test Plan lacks details and no justification is provided for omitting automated tests. Please update the PR body to include either automated tests (preferred) or a clear manual test plan and justification for why automated tests were not added. Also expand the Impact section slightly to call out background process and developer implications.
Additional code-surface recommendation (non-blocking for PR-body compliance but relevant to reviewers/authors): the added calls in CreateLogicAppProjects.ts invoke getAzureConnectorDetailsForLocalProject(...) and startDesignTimeApi(...). If these utilities return promises, consider awaiting them or documenting intended async behavior and error handling — and include verification steps in the Test Plan that these operations completed successfully.
Please update the PR title/body as recommended above, add the test details (or tests), and then re-submit. Thank you for helping maintain high-quality PR documentation for the team!
Last updated: Thu, 08 Jan 2026 19:34:26 GMT
🤖 AI PR Validation ReportPR Review ResultsThank you for your submission! Here's detailed feedback on your PR title and body compliance:✅ PR Title
✅ Commit Type
✅ Risk Level
✅ What & Why
✅ Impact of Change
✅ Test Plan
✅ Contributors
✅ Screenshots/Videos
Summary Table
The PR passes all body and title checks, and the risk level is correct. No changes required. Thank you for maintaining clear, concise documentation in your PR! Last updated: Fri, 21 Nov 2025 19:38:41 GMT |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
This PR fixes an inconsistency between the "Create new workspace" and "Create new project" flows by adding Azure connector details prompting and design-time host initialization to the project creation process. Previously, these initialization steps were only performed for workspace creation, leaving newly created projects without immediate Azure connector configuration or a running design-time API.
Key changes:
- Added calls to
getAzureConnectorDetailsForLocalProject()andstartDesignTimeApi()at the end of thecreateLogicAppProject()function - Added a blank line formatting improvement in
azureConnectorWizard.ts
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| apps/vs-code-designer/src/app/commands/workflows/azureConnectorWizard.ts | Minor formatting change - added blank line after function definition |
| apps/vs-code-designer/src/app/commands/createNewCodeProject/CodeProjectBase/CreateLogicAppProjects.ts | Added Azure connector details prompting and design-time API initialization calls after project creation, with necessary imports |
...ode-designer/src/app/commands/createNewCodeProject/CodeProjectBase/CreateLogicAppProjects.ts
Show resolved
Hide resolved
apps/vs-code-designer/src/app/commands/workflows/azureConnectorWizard.ts
Show resolved
Hide resolved
…ridge/newProjectDesignTimeFix
Fixes #6824
Commit Type
Risk Level
What & Why
Adds the following initialization steps at end of 'Create new project' flow:
Impact of Change
Test Plan
Contributors
@andrew-eldridge