Skip to content

Conversation

@andrew-eldridge
Copy link
Contributor

@andrew-eldridge andrew-eldridge commented Nov 21, 2025

Fixes #6824

Commit Type

  • feature - New functionality
  • fix - Bug fix
  • refactor - Code restructuring without behavior change
  • perf - Performance improvement
  • docs - Documentation update
  • test - Test-related changes
  • chore - Maintenance/tooling

Risk Level

  • Low - Minor changes, limited scope
  • Medium - Moderate changes, some user impact
  • High - Major changes, significant user/system impact

What & Why

Adds the following initialization steps at end of 'Create new project' flow:

  • Prompts for azure connector details
  • Starts design-time host for the new project

Impact of Change

  • Users: Fixes incongruency between 'Create new workspace' and 'Create new project' where the latter doesn't immediately get azure connector details or start design-time
  • Developers: N/A
  • System: N/A

Test Plan

  • Unit tests added/updated
  • E2E tests added/updated
  • Manual testing completed
  • Tested in:

Contributors

@andrew-eldridge

@andrew-eldridge andrew-eldridge added the VSCode Issues or PRs specific to VS Code extension label Nov 21, 2025
Copilot AI review requested due to automatic review settings November 21, 2025 19:38
@andrew-eldridge andrew-eldridge added risk:low Low risk change with minimal impact bug Something isn't working labels Nov 21, 2025
@github-actions
Copy link

github-actions bot commented Nov 21, 2025

🤖 AI PR Validation Report

PR Review Results

Thank you for your submission! Here's detailed feedback on your PR title and body compliance:

PR Title

  • Current: fix(vscode): Prompt for azure connector details and start design-time host on new projects
  • Issue: None — title is concise and describes the change and scope (VS Code extension).
  • Recommendation: Keep as-is. If you want to be extra explicit, you could include the specific command/flow name that is changed (e.g., Create new project flow) but this is optional.

Commit Type

  • Properly selected (fix).
  • Note: Only one commit type is selected which is correct.

Risk Level

  • The PR contains the risk:low label and the PR body selected Low.
  • Assessment: The code diff is small (7 additions, 0 deletions across 2 files) and the change surface is limited to the create-new-project flow, so risk:low is consistent with the diff.

⚠️ What & Why

  • Current: Adds the following initialization steps at end of 'Create new project' flow: - Prompts for azure connector details - Starts design-time host for the new project
  • Issue: The What & Why is brief but acceptable. It could be slightly expanded to mention if these functions are new upstream utilities or existing helpers and whether any side-effects (background processes) are expected.
  • Recommendation: Add a single sentence clarifying whether these are synchronous or asynchronous operations and whether they require additional permissions or environment dependencies. Example: These calls trigger an interactive azure connector prompt (UI) and start a local design-time host process for the new project; both run asynchronously in the background.

Impact of Change

  • Issue: The Impact section is minimal. Developers and System are marked as N/A, but the code change does start background behavior (design-time host) and invokes connector prompts — these can have developer/system implications.
  • Recommendation:
    • Users: Clarify the user experience change (e.g., users will now be prompted immediately after project creation and a local host process will be started automatically). Example: Users: After creating a new project they'll be prompted to provide Azure connector details and the design-time host will be started automatically so the project is ready for local testing.
    • Developers: Note any added dependencies, new utilities used, or expectations for handling asynchronous behavior. Example: Developers: Adds two utility calls (getAzureConnectorDetailsForLocalProject and startDesignTimeApi). Ensure teams know these functions run on project creation and may surface authentication dialogs.
    • System: Note background process and potential port/host usage or side effects. Example: System: Starts a local design-time host process; document expected ports and resource use.

Test Plan

  • Assessment: The PR marks Manual testing completed but provides no details about what was manually tested (steps, environment, expected results). There are no unit tests or E2E tests added and there is no explanation why automated tests were not added.
  • Why this fails the check: Per the repository checklist, if no unit tests and no E2E tests are added, the PR must include a clear explanation of why those tests were omitted. That explanation and detailed manual test steps are missing.
  • Recommendation (required to pass):
    • Add one of the following:
      • Unit tests (or E2E tests) covering the new initialization logic (e.g., mock getAzureConnectorDetailsForLocalProject and startDesignTimeApi calls and verify they're invoked during project creation), or
      • A clear explanation in the Test Plan describing why automated tests are not practical for this change plus detailed manual test steps and environments.
    • Provide explicit manual test steps that were executed and their results, for example:
      1. Create a new project via VS Code command ...
      2. Confirm the Azure connector prompt appears and accepts valid credentials.
      3. Verify the design-time host process is started and reachable at http://localhost:PORT.
      4. Confirm no unhandled errors are logged and that project creation completes with the final success message.
    • If the functions are asynchronous, indicate how you verified they completed successfully (e.g., logs, UI indicators).

⚠️ Contributors

  • Assessment: @andrew-eldridge is listed in Contributors. Good. If any PMs/designers/testers assisted, consider mentioning them.
  • Recommendation: If others helped (design, QA), add them here to credit contributions.

⚠️ Screenshots/Videos

  • Assessment: Not applicable / not provided.
  • Recommendation: Optional but helpful for UI changes — consider adding a short screenshot or terminal log showing the connector prompt and design-time host start if available.

Summary Table

Section Status Recommendation
Title No change required
Commit Type No change required
Risk Level Label matches change
What & Why ⚠️ Add a short note about async behavior/side-effects
Impact of Change Clarify Users/Developers/System impacts
Test Plan Add unit/E2E tests or detailed manual test steps + rationale
Contributors ⚠️ Optional: add other contributors if applicable
Screenshots/Videos ⚠️ Optional: add if UI/UX changed

Final message
This PR does not pass the PR-body compliance check because the Test Plan lacks details and no justification is provided for omitting automated tests. Please update the PR body to include either automated tests (preferred) or a clear manual test plan and justification for why automated tests were not added. Also expand the Impact section slightly to call out background process and developer implications.

Additional code-surface recommendation (non-blocking for PR-body compliance but relevant to reviewers/authors): the added calls in CreateLogicAppProjects.ts invoke getAzureConnectorDetailsForLocalProject(...) and startDesignTimeApi(...). If these utilities return promises, consider awaiting them or documenting intended async behavior and error handling — and include verification steps in the Test Plan that these operations completed successfully.

Please update the PR title/body as recommended above, add the test details (or tests), and then re-submit. Thank you for helping maintain high-quality PR documentation for the team!


Last updated: Thu, 08 Jan 2026 19:34:26 GMT

@github-actions
Copy link

🤖 AI PR Validation Report

PR Review Results

Thank you for your submission! Here's detailed feedback on your PR title and body compliance:

PR Title

  • Current: fix(vscode): Prompt for azure connector details and start design-time host on new projects
  • Issue: Title is specific, includes area affected, nature of fix, and scope
  • Recommendation: None needed. This is an ideal PR title.

Commit Type

  • Properly selected (fix)
  • Only one selected, which is correct

Risk Level

  • Risk level "Low" is selected. PR is labeled "Risk:Low", and based on the code change (small, targeted, 7 additions, no deletions, scope limited to initialization after project creation), this is appropriate.

What & Why

  • Current: Adds the following initialization steps at end of 'Create new project' flow:
  • Prompts for azure connector details
  • Starts design-time host for the new project
  • Issue: Clear, brief, describes what was changed and why (adds missing initialization step).
  • Recommendation: None needed.

Impact of Change

  • Clear indication of impact to users (addressing missing initialization after project creation), developers (N/A), and system (N/A).
  • Recommendation: Users: Clear
    • Developers: N/A, but could explicitly state if there are any expected developer-facing changes or workflow impact (optional)
    • System: N/A, but if system behavior changes (dependencies, broader impact), mention (optional)

Test Plan

  • "Manual testing completed" is checked, which is common for small workflow fixes. No unit/E2E test required for a simple UX fix.

Contributors

  • @andrew-eldridge listed
  • Minimal, but if more contributors (PM, Design) helped, tagging them is appreciated (optional)

Screenshots/Videos

  • Not needed for backend/initialization workflow change. Section left blank, this passes.

Summary Table

Section Status Recommendation
Title None
Commit Type None
Risk Level None
What & Why None
Impact of Change None
Test Plan None
Contributors Optional: Tag PMs/designers if they contributed
Screenshots/Videos None

The PR passes all body and title checks, and the risk level is correct. No changes required. Thank you for maintaining clear, concise documentation in your PR!


Last updated: Fri, 21 Nov 2025 19:38:41 GMT

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR fixes an inconsistency between the "Create new workspace" and "Create new project" flows by adding Azure connector details prompting and design-time host initialization to the project creation process. Previously, these initialization steps were only performed for workspace creation, leaving newly created projects without immediate Azure connector configuration or a running design-time API.

Key changes:

  • Added calls to getAzureConnectorDetailsForLocalProject() and startDesignTimeApi() at the end of the createLogicAppProject() function
  • Added a blank line formatting improvement in azureConnectorWizard.ts

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.

File Description
apps/vs-code-designer/src/app/commands/workflows/azureConnectorWizard.ts Minor formatting change - added blank line after function definition
apps/vs-code-designer/src/app/commands/createNewCodeProject/CodeProjectBase/CreateLogicAppProjects.ts Added Azure connector details prompting and design-time API initialization calls after project creation, with necessary imports

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working needs-pr-update risk:low Low risk change with minimal impact VSCode Issues or PRs specific to VS Code extension

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Options like "host.json" and "local.settings.json" under workflow_designtime are not appearing as expected.

3 participants