Skip to content

Fix: consumption SKU agent runAfter bug — restore runAfter when re-adding agent loop #8663

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wgrooversoftie wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Fix: consumption SKU agent runAfter bug — restore runAfter when re-adding agent loop #8663

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
9eb1f68
Fix: Support consumption SKU A2A workflows in parser files
wgrooversoftie Dec 2, 2025
ad64a21
test: Add comprehensive unit tests for isA2AWorkflow helper
wgrooversoftie Dec 15, 2025
fbf4534
Merge branch 'Azure:main' into fix/consumption-sku-agent-runafter-bug
wgrooversoftie Jan 6, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions libs/designer-v2/src/lib/core/parsers/addNodeToWorkflow.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,7 @@
import CONSTANTS from '../../common/constants';
import type { RelationshipIds } from '../state/panel/panelTypes';
import type { NodesMetadata, WorkflowState } from '../state/workflow/workflowInterfaces';
import { isA2AWorkflow } from '../state/workflow/helper';
import { createWorkflowNode, createWorkflowEdge } from '../utils/graph';
import type { WorkflowEdge, WorkflowNode } from './models/workflowNode';
import { reassignEdgeSources, reassignEdgeTargets, addNewEdge, applyIsRootNode, removeEdge } from './restructuringHelpers';
Expand All @@ -13,7 +14,6 @@ import {
isScopeOperation,
WORKFLOW_NODE_TYPES,
getRecordEntry,
equals,
} from '@microsoft/logic-apps-shared';

export interface AddNodePayload {
Expand Down Expand Up @@ -53,7 +53,7 @@ export const addNodeToWorkflow = (
state.isDirty = true;

const isAfterTrigger = getRecordEntry(nodesMetadata, parentId ?? '')?.isTrigger;
const allowRunAfterTrigger = equals(state.workflowKind, 'agent');
const allowRunAfterTrigger = isA2AWorkflow(state);
const shouldAddRunAfters = allowRunAfterTrigger || (!isRoot && !isAfterTrigger);
nodesMetadata[newNodeId] = { graphId: subgraphId ?? graphId, parentNodeId, isRoot, isTrigger };
state.operations[newNodeId] = { ...state.operations[newNodeId], type: operation.type, kind: operation.kind };
Expand Down
3 changes: 2 additions & 1 deletion libs/designer-v2/src/lib/core/parsers/deleteNodeFromWorkflow.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,6 @@
/* eslint-disable no-param-reassign */
import type { NodesMetadata, WorkflowState } from '../state/workflow/workflowInterfaces';
import { isA2AWorkflow } from '../state/workflow/helper';
import type { WorkflowNode } from './models/workflowNode';
import { removeEdge, reassignEdgeSources, reassignEdgeTargets } from './restructuringHelpers';
import { equals, getRecordEntry, type LogicAppsV2 } from '@microsoft/logic-apps-shared';
Expand Down Expand Up @@ -80,7 +81,7 @@ export const deleteNodeFromWorkflow = (
const parentId = (workflowGraph.edges ?? []).find((edge) => edge.target === nodeId)?.source ?? '';
const parentMetadata = getRecordEntry(nodesMetadata, parentId);
const isAfterTrigger = parentMetadata?.isTrigger;
const allowRunAfterTrigger = equals(state.workflowKind, 'agent');
const allowRunAfterTrigger = isA2AWorkflow(state);
const shouldAddRunAfters = allowRunAfterTrigger || (!isRoot && !isAfterTrigger);
reassignEdgeSources(state, nodeId, parentId, workflowGraph, shouldAddRunAfters);
removeEdge(state, parentId, nodeId, workflowGraph);
Expand Down
7 changes: 4 additions & 3 deletions libs/designer-v2/src/lib/core/parsers/moveNodeInWorkflow.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,10 +1,11 @@
/* eslint-disable no-param-reassign */
import type { RelationshipIds } from '../state/panel/panelTypes';
import type { NodesMetadata, WorkflowState } from '../state/workflow/workflowInterfaces';
import { isA2AWorkflow } from '../state/workflow/helper';
import type { WorkflowNode } from './models/workflowNode';
import { addNewEdge, reassignEdgeSources, reassignEdgeTargets, removeEdge, applyIsRootNode } from './restructuringHelpers';
import type { LogicAppsV2 } from '@microsoft/logic-apps-shared';
import { containsIdTag, equals, getRecordEntry } from '@microsoft/logic-apps-shared';
import { containsIdTag, getRecordEntry } from '@microsoft/logic-apps-shared';

export interface MoveNodePayload {
nodeId: string;
Expand Down Expand Up @@ -73,7 +74,7 @@ export const moveNodeInWorkflow = (
const parentId = (oldWorkflowGraph.edges ?? []).find((edge) => edge.target === nodeId)?.source ?? '';
const parentMetadata = getRecordEntry(nodesMetadata, parentId);
const isAfterTrigger = parentMetadata?.isTrigger;
const allowRunAfterTrigger = equals(state.workflowKind, 'agent');
const allowRunAfterTrigger = isA2AWorkflow(state);
const shouldAddRunAfters = allowRunAfterTrigger || (!isOldRoot && !isAfterTrigger);
reassignEdgeSources(state, nodeId, parentId, oldWorkflowGraph, shouldAddRunAfters);
removeEdge(state, parentId, nodeId, oldWorkflowGraph);
Expand Down Expand Up @@ -105,7 +106,7 @@ export const moveNodeInWorkflow = (

const parentMetadata = getRecordEntry(nodesMetadata, parentId);
const isAfterTrigger = (parentMetadata?.isRoot && newGraphId === 'root') ?? false;
const allowRunAfterTrigger = equals(state.workflowKind, 'agent');
const allowRunAfterTrigger = isA2AWorkflow(state);
const shouldAddRunAfters = allowRunAfterTrigger || (!isNewRoot && !isAfterTrigger);

// 1 parent, 1 child
Expand Down
5 changes: 3 additions & 2 deletions libs/designer-v2/src/lib/core/parsers/pasteScopeInWorkflow.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,8 +1,9 @@
import type { RelationshipIds } from '../state/panel/panelTypes';
import type { NodesMetadata, Operations, WorkflowState } from '../state/workflow/workflowInterfaces';
import { isA2AWorkflow } from '../state/workflow/helper';
import type { WorkflowNode } from './models/workflowNode';
import { addNewEdge, reassignEdgeSources, reassignEdgeTargets, removeEdge, applyIsRootNode } from './restructuringHelpers';
import { containsIdTag, equals, getRecordEntry } from '@microsoft/logic-apps-shared';
import { containsIdTag, getRecordEntry } from '@microsoft/logic-apps-shared';

export interface PasteScopeNodePayload {
relationshipIds: RelationshipIds;
Expand Down Expand Up @@ -56,7 +57,7 @@ export const pasteScopeInWorkflow = (

const parentMetadata = getRecordEntry(state.nodesMetadata, parentId);
const isAfterTrigger = (parentMetadata?.isRoot && newGraphId === 'root') ?? false;
const allowRunAfterTrigger = equals(state.workflowKind, 'agent');
const allowRunAfterTrigger = isA2AWorkflow(state);
const shouldAddRunAfters = allowRunAfterTrigger || (!isNewRoot && !isAfterTrigger);

// clear the existing runAfter
Expand Down
Loading
Loading