(feat:designer) Support dynamic list for MCP client tool actions #8690
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🤖 AI PR Validation ReportPR Review ResultsThank you for your submission! Here's detailed feedback on your PR title and body compliance:
|
| Section | Status | Recommendation |
|---|---|---|
| Title | Use conventional commit style and tighten wording (e.g., feat(designer): add dynamic list support for MCP client tools) |
|
| Commit Type | ✅ | None |
| Risk Level | ❌ | Change to Medium and update label & PR body to reflect runtime impact and workflow requirement |
| What & Why | ✅ | Expand to call out workflowName requirement and backward-compat expectations |
| Impact of Change | Fill System section and call out runtime HTTP call and sanitization of connection properties | |
| Test Plan | ✅ | Unit tests present. Consider E2E/integration justification or add an integration test if possible |
| Contributors | Add contributors or a short credit line (optional but recommended) | |
| Screenshots/Videos | Add visual proof if this affects the editor UX (recommended) |
Final notes
- Advised risk level: risk:medium — this is higher than the
risk:lowcurrently selected. Please update the PR risk selection and label to reflect this. The reasoning: the PR touches runtime connector flows (StandardConnectorService), adds a required runtime context (workflowName) for MCP flows, and changes operation metadata and dynamic-list plumbing across multiple core libraries. These are additive but introduce new runtime behavior and a failing condition if workflowName is missing. - Title: please adopt conventional commit style and make it concise as suggested.
- Body: explicitly document the new runtime requirement (workflowName) and any deployment/upgrade guidance (e.g., ensure services that instantiate StandardConnectorService pass workflowName). Also include a short note about backward compatibility.
Please update the PR title, the Risk Level selection in the PR body (and add the risk:medium label), and expand the Impact/System details. Once updated, this PR looks good to merge from a PR-body/template perspective.
Last updated: Fri, 09 Jan 2026 04:55:34 GMT
Contributor
There was a problem hiding this comment.
Pull request overview
This pull request adds support for dynamic list functionality in MCP (Model Context Protocol) tools, enabling users to select tools from a dropdown rather than manually typing tool names. The feature is implemented but currently disabled (commented out in the manifest) pending backend deployment.
Key Changes
- Extended operation metadata to include
operationPathfor MCP operations - Implemented dynamic tool listing via the
listMcpToolsAPI endpoint - Updated connection configuration handling to support both agent-based and managed MCP connections
Reviewed changes
Copilot reviewed 18 out of 18 changed files in this pull request and generated 9 comments.
Show a summary per file
| File | Description |
|---|---|
| libs/logic-apps-shared/src/utils/src/lib/models/operationmanifest.ts | Added optional operationPath field to OperationInfo interface |
| libs/logic-apps-shared/src/designer-client-services/lib/standard/manifest/builtinmcpclient.ts | Updated manifest with commented-out dynamic list configuration for MCP tools |
| libs/logic-apps-shared/src/designer-client-services/lib/standard/connector.ts | Added MCP-specific logic to _listDynamicValues method and updated service options to include workflowName |
| libs/logic-apps-shared/src/designer-client-services/lib/connector.ts | Extended IConnectorService interface to include operationPath parameter |
| libs/designer/src/lib/core/utils/parameters/dynamicdata.ts | Updated to pass operationPath to dynamic values queries |
| libs/designer/src/lib/core/state/operation/operationMetadataSlice.ts | Modified to store operationPath in operation info state |
| libs/designer/src/lib/core/queries/connector.ts | Updated query to include operationPath parameter |
| libs/designer/src/lib/core/actions/bjsworkflow/operationdeserializer.ts | Updated to initialize operation info with operationPath |
| libs/designer/src/lib/core/actions/bjsworkflow/add.ts | Added logic to extract and store operationPath from swagger for managed MCP clients |
| libs/designer-v2/src/lib/core/utils/parameters/dynamicdata.ts | Updated to pass operationPath to dynamic values queries (v2) |
| libs/designer-v2/src/lib/core/state/operation/operationMetadataSlice.ts | Modified to store operationPath in operation info state (v2) |
| libs/designer-v2/src/lib/core/queries/connector.ts | Updated query to include operationPath parameter (v2) |
| libs/designer-v2/src/lib/core/actions/bjsworkflow/operationdeserializer.ts | Updated to initialize operation info with operationPath (v2) |
| libs/designer-v2/src/lib/core/actions/bjsworkflow/test/operationdeserializer.spec.ts | Added test assertion for operationPath in operation info |
| apps/Standalone/src/templates/app/TemplatesStandard.tsx | Added required workflowName parameter (empty string) to connector service |
| apps/Standalone/src/mcp/app/McpStandard.tsx | Added required workflowName parameter (empty string) to connector service |
| apps/Standalone/src/designer/app/AzureLogicAppsDesigner/laDesignerV2.tsx | Updated connection configuration function and modified readonly logic |
| apps/Standalone/src/designer/app/AzureLogicAppsDesigner/laDesigner.tsx | Updated connection configuration to support MCP connections |
|
📊 Coverage check completed. See workflow run for details. |
anthony0t
changed the title
anthony0t
force-pushed
the
tonytang/mcptool
branch
from
8fe526f to
c7677f1
Compare
|
📊 Coverage check completed. See workflow run for details. |
14 tasks
takyyon
approved these changes
Jan 9, 2026
anthony0t
force-pushed
the
tonytang/mcptool
branch
from
c7677f1 to
9dab94d
Compare
|
📊 Coverage check completed. See workflow run for details. |
1 similar comment
|
📊 Coverage check completed. See workflow run for details. |
14 tasks
anthony0t
force-pushed
the
tonytang/mcptool
branch
from
9dab94d to
d1a82bc
Compare
|
📊 Coverage check completed. See workflow run for details. |
anthony0t
force-pushed
the
tonytang/mcptool
branch
from
d1a82bc to
ea3a0de
Compare
|
📊 Coverage check completed. See workflow run for details. |
anthony0t
changed the title
takyyon
approved these changes
Jan 9, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Commit Type
Risk Level
What & Why
Adding support for dynamic list in mcp tools so user can choose the tools they want, rather than having to manually type in the tools which is difficult for them. This PR adds the capability. The capability is purely additive and doesn't impact existing features.
Impact of Change
User will be able to choose the tools now instead of manually type them in.
if dynamic list on MCP client tool feature is needed, workflowName needs to be passed to connector service, and getConfiguration callback needs to support new optional parameters. If this feature is not needed, no change is needed.
Test Plan
Contributors
Screenshots/Videos