-
Notifications
You must be signed in to change notification settings - Fork 610
[DRAFT] FEAT Dataset Loading Utilities #1201
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
ValbuenaVC
wants to merge
2
commits into
Azure:main
Choose a base branch
from
ValbuenaVC:dataset_load_utils
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+66
−13
Draft
Changes from all commits
Commits
Show all changes
2 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,10 @@ | ||
| # Copyright (c) Microsoft Corporation. | ||
| # Licensed under the MIT license. | ||
|
|
||
| """Dataset classes for scenario data loading.""" | ||
|
|
||
| from pyrit.scenario.dataset.load_utils import ScenarioDatasetUtils | ||
|
|
||
| __all__ = [ | ||
| "ScenarioDatasetUtils" | ||
| ] |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,36 @@ | ||
| # Copyright (c) Microsoft Corporation. | ||
| # Licensed under the MIT license. | ||
|
|
||
| from pathlib import Path | ||
| from typing import List | ||
| from pyrit.models import SeedDataset | ||
| from pyrit.common.path import DATASETS_PATH, SCORER_CONFIG_PATH | ||
| from pyrit.datasets.harmbench_dataset import fetch_harmbench_dataset | ||
|
|
||
|
|
||
| class ScenarioDatasetUtils: | ||
| """ | ||
| Set of dataset loading utilities for Scenario class. | ||
| """ | ||
| @classmethod | ||
| def seed_dataset_to_list_str(cls, dataset: Path) -> List[str]: | ||
| seed_prompts: List[str] = [] | ||
| seed_prompts.extend(SeedDataset.from_yaml_file(dataset).get_values()) | ||
| return seed_prompts | ||
|
|
||
| @classmethod | ||
| def get_seed_dataset(cls, which: str) -> SeedDataset: | ||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Which is not a common parameter naming choice. Name seems preferable. |
||
| """ | ||
| Get SeedDataset from shorthand string. | ||
| Args: | ||
| which (str): Which SeedDataset. | ||
| Returns: | ||
| SeedDataset: Desired dataset. | ||
| Raises: | ||
| ValueError: If dataset not found. | ||
| """ | ||
| match which: | ||
| case "harmbench": | ||
| return fetch_harmbench_dataset() | ||
| case _: | ||
| raise ValueError(f"Error: unknown dataset `{which}` provided.") | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,5 @@ | ||
| # Copyright (c) Microsoft Corporation. | ||
| # Licensed under the MIT license. | ||
|
|
||
| """Tests for the scenarios.ScenarioDatasetUtils class.""" | ||
|
|
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm kind of surprised we're using these as plain strings. It loses all the metadata. That means we lose harm categories, for example. How will one query for the results?