Skip to content

Rework FreeBSDResourceDiskHandler#1892

Open
lwhsu wants to merge 1 commit intoAzure:developfrom
lwhsu:freebsd-resourcedisk
Open

Rework FreeBSDResourceDiskHandler#1892
lwhsu wants to merge 1 commit intoAzure:developfrom
lwhsu:freebsd-resourcedisk

Conversation

@lwhsu
Copy link
Contributor

@lwhsu lwhsu commented May 22, 2020

Description

Replace using a swap file in the file system of the resource disk by
using a swap partition, which is the preferred swap device. This also
avoids using the slower posix_fallocate(2) and helps increasing VM
provision speed.

Also add support for generation 2 VMs.


PR information

  • The title of the PR is clear and informative.
  • There are a small number of commits, each of which has an informative message. This means that previously merged commits do not appear in the history of the PR. For information on cleaning up the commits in your pull request, see this page.
  • Except for special cases involving multiple contributors, the PR is started from a fork of the main repository, not a branch.
  • If applicable, the PR references the bug/issue that it fixes in the description.
  • New Unit tests were added for the changes made and Travis.CI is passing.

Quality of Code and Contribution Guidelines

@msftclas
Copy link

msftclas commented May 22, 2020

CLA assistant check
All CLA requirements met.

@codecov
Copy link

codecov bot commented May 22, 2020

Codecov Report

Merging #1892 (88ad74e) into develop (a07e48a) will decrease coverage by 1.54%.
The diff coverage is 5.83%.

❗ Current head 88ad74e differs from pull request most recent head 54de935. Consider uploading reports for the commit 54de935 to get more accurate results

@@             Coverage Diff             @@
##           develop    #1892      +/-   ##
===========================================
- Coverage    71.95%   70.40%   -1.55%     
===========================================
  Files          104       97       -7     
  Lines        15765    14053    -1712     
  Branches      2244     2026     -218     
===========================================
- Hits         11343     9894    -1449     
+ Misses        3906     3712     -194     
+ Partials       516      447      -69     
Impacted Files Coverage Δ
azurelinuxagent/daemon/resourcedisk/freebsd.py 11.44% <5.83%> (-1.43%) ⬇️
azurelinuxagent/common/protocol/goal_state.py 91.64% <0.00%> (-3.12%) ⬇️
azurelinuxagent/ga/update.py 87.62% <0.00%> (-3.09%) ⬇️
azurelinuxagent/common/conf.py 77.25% <0.00%> (-2.59%) ⬇️
azurelinuxagent/common/cgroupstelemetry.py 98.11% <0.00%> (-1.89%) ⬇️
azurelinuxagent/common/utils/cryptutil.py 43.92% <0.00%> (-1.87%) ⬇️
azurelinuxagent/common/protocol/hostplugin.py 85.99% <0.00%> (-1.78%) ⬇️
azurelinuxagent/common/cgroupconfigurator.py 70.50% <0.00%> (-1.43%) ⬇️
azurelinuxagent/agent.py 57.43% <0.00%> (-1.20%) ⬇️
azurelinuxagent/common/protocol/wire.py 77.36% <0.00%> (-0.88%) ⬇️
... and 39 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@narrieta narrieta requested review from trstringer and removed request for ZhidongPeng, larohra, narrieta and pgombar May 22, 2020 15:19
@lwhsu lwhsu force-pushed the freebsd-resourcedisk branch 2 times, most recently from 65e7a56 to 2bfe70d Compare May 23, 2020 01:45
uqs pushed a commit to freebsd/freebsd-ports that referenced this pull request May 23, 2020
- Pull in the patch from Azure/WALinuxAgent#1892
- Drop patch to create large swap space, leave some more space for temporarily
  storage

Approved by:	maintainer (implicitly)
Sponsored by:	The FreeBSD Foundation


git-svn-id: svn+ssh://svn.freebsd.org/ports/head@536262 35697150-7ecd-e111-bb59-0022644237b5
uqs pushed a commit to freebsd/freebsd-ports that referenced this pull request May 23, 2020
- Pull in the patch from Azure/WALinuxAgent#1892
- Drop patch to create large swap space, leave some more space for temporarily
  storage

Approved by:	maintainer (implicitly)
Sponsored by:	The FreeBSD Foundation
Jehops pushed a commit to Jehops/freebsd-ports-legacy that referenced this pull request May 23, 2020
- Pull in the patch from Azure/WALinuxAgent#1892
- Drop patch to create large swap space, leave some more space for temporarily
  storage

Approved by:	maintainer (implicitly)
Sponsored by:	The FreeBSD Foundation


git-svn-id: svn+ssh://svn.freebsd.org/ports/head@536262 35697150-7ecd-e111-bb59-0022644237b5
uqs pushed a commit to freebsd/freebsd-ports that referenced this pull request May 26, 2020
Adjust WALinuxAgent to be more sutiable for FreeBSD:

- Pull in the patch from Azure/WALinuxAgent#1892
- Drop patch to create large swap space, leave some more space for temporarily
  storage

Approved by:	maintainer (implicitly)
Sponsored by:	The FreeBSD Foundation

Approved by:	portmgr (bapt)
uqs pushed a commit to freebsd/freebsd-ports that referenced this pull request Apr 1, 2021
Adjust WALinuxAgent to be more sutiable for FreeBSD:

- Pull in the patch from Azure/WALinuxAgent#1892
- Drop patch to create large swap space, leave some more space for temporarily
  storage

Approved by:	maintainer (implicitly)
Sponsored by:	The FreeBSD Foundation

Approved by:	portmgr (bapt)
@lwhsu lwhsu force-pushed the freebsd-resourcedisk branch from 22fdbdc to 7b65f8e Compare May 23, 2021 10:18
@lwhsu lwhsu force-pushed the freebsd-resourcedisk branch 4 times, most recently from aedf335 to 6eb63a4 Compare May 23, 2021 16:22
@lwhsu
Copy link
Contributor Author

lwhsu commented May 23, 2021

@trstringer Please review and merge this. Thanks!

@lwhsu lwhsu force-pushed the freebsd-resourcedisk branch from 6eb63a4 to 9039cec Compare July 27, 2021 21:13
@lwhsu lwhsu requested a review from nagworld9 as a code owner July 27, 2021 21:13
@lwhsu lwhsu force-pushed the freebsd-resourcedisk branch from 9039cec to 88ad74e Compare July 27, 2021 21:50
Replace using a swap file in the file system of the resource disk by
using a swap partition, which is the preferred swap device.  This also
avoids using the slower posix_fallocate(2) and helps increasing VM
provision speed.
@lwhsu lwhsu force-pushed the freebsd-resourcedisk branch from 88ad74e to 54de935 Compare December 1, 2022 10:32
@lwhsu lwhsu requested a review from maddieford as a code owner December 1, 2022 10:32
@svmhdvn
Copy link

svmhdvn commented Jan 13, 2026

I'd like to request a review of this PR if possible. We are still carrying this patch downstream (https://cgit.freebsd.org/ports/tree/sysutils/azure-agent/files/patch-azurelinuxagent_daemon_resourcedisk_freebsd.py) and would like to upstream it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants