fix(init): ensure waagent service starts after cloud-init.service

[cjp256]

cloud-init.service is responsible for setting up disks during provisioning. Since waagent may perform operations to configure swap, wait until after cloud-init.service is complete.

This effectively updates all distros to match behavior already done for Mariner and Ubuntu.

Description

Issue #

---

PR information

• The title of the PR is clear and informative.
• There are a small number of commits, each of which has an informative message. This means that previously merged commits do not appear in the history of the PR. For information on cleaning up the commits in your pull request, see this page.
• If applicable, the PR references the bug/issue that it fixes in the description.
• New Unit tests were added for the changes made

Quality of Code and Contribution Guidelines

• I have read the contribution guidelines.

[nagworld9]

@cjp256

cloud-init.service is responsible for setting up disks during provisioning. Since waagent may perform operations to configure swap, wait until after cloud-init.service is complete.

if this is the motivation, will after target ensure waagent service start only after cloud-init service finishes disk operation?

[nmeyerhans]

Note that as of cloud-init 24.3, cloud-init.service no longer exists, having been renamed to cloud-init-network.service. You'll probably want an After= on that service as well. See canonical/cloud-init#5489

[holmanb]

Note that as of cloud-init 24.3, cloud-init.service no longer exists, having been renamed to cloud-init-network.service. You'll probably want an After= on that service as well. See canonical/cloud-init#5489

cloud-config.target is ordered after the network stage both before and after 24.3, so if you would prefer to order after a single unit, that should suffice in all cases.

[cjp256]

Note that as of cloud-init 24.3, cloud-init.service no longer exists, having been renamed to cloud-init-network.service. You'll probably want an After= on that service as well. See canonical/cloud-init#5489

cloud-config.target is ordered after the network stage both before and after 24.3, so if you would prefer to order after a single unit, that should suffice in all cases.

Great points! Will update it