Use nmcli to set DHCP hostname for modern RHEL distros#3243
Open
vittyvk wants to merge 1 commit intoAzure:developfrom
Open
Use nmcli to set DHCP hostname for modern RHEL distros#3243vittyvk wants to merge 1 commit intoAzure:developfrom
vittyvk wants to merge 1 commit intoAzure:developfrom
Conversation
vittyvk
requested review from
ZhidongPeng,
maddieford,
nagworld9 and
narrieta
as code owners
Contributor
Author
|
ping? |
Contributor
|
Hi @vittyvk, thank you for opening this. It's in our backlog to review+test |
|
references #2640 |
RHEL8+ uses NetworkManager and the most recent RHEL10 switched to using built-in dhcp client making DefaultOSUtil.set_dhcp_hostname() unsuitable. In fact, RHEL distos had been carrying RHEL-only downstream patch replacing RedhatOSModernUtil.set_dhcp_hostname() with nmcli device modify <DEV> ipv4.dhcp-hostname <HOSTNAME ipv6.dhcp-hostname <HOSTNAME> since RHEL8 but this is also not ideal as 'nmcli device modify' does not persist the change. Complement this with 'nmcli connection modify' to both make the immediate change and persist it. Signed-off-by: Vitaly Kuznetsov <vkuznets@redhat.com>
Contributor
Author
|
While this is still on review, I added a simple re-try mechanism for 'nmcli device modify' as it was found that this action can coincide with NetworkManager's interface re-configuration. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
RHEL8+ uses NetworkManager and the most recent RHEL10 switched to using built-in dhcp client making DefaultOSUtil.set_dhcp_hostname() unsuitable. In fact, RHEL distos had been carrying RHEL-only downstream patch replacing RedhatOSModernUtil.set_dhcp_hostname() with
nmcli device modify ipv4.dhcp-hostname <HOSTNAME ipv6.dhcp-hostname
since RHEL8 but this is also not ideal as 'nmcli device modify' does not persist the change. Do 'nmcli connection modify' instead.
Issue #
PR information
Quality of Code and Contribution Guidelines