Require Hyper-V to start waagent service#3334
Open
vittyvk wants to merge 1 commit intoAzure:developfrom
Open
Conversation
WALinuxAgent is Azure specific and Azure runs on Hyper-V. Add ConditionVirtualization=microsoft to service files to avoid starting WALA in other environments. In particular, this avoids polluting the console when the same image is used both for Azure and some other env (e.g. local QEMU). Signed-off-by: Vitaly Kuznetsov <vkuznets@redhat.com>
Member
|
@anhvoms - could you take a look? |
jeremycline
approved these changes
May 16, 2025
Member
jeremycline
left a comment
There was a problem hiding this comment.
For what it's worth, this looks good to me and helps reduce the patches distributions have to carry. There's a slight deviation from Fedora's downstream patch by Chris, but I think it's okay unless he has strong feelings about it being a triggering conditional.
|
|
||
| ConditionFileIsExecutable=/usr/sbin/waagent | ||
| ConditionPathExists=/etc/waagent.conf | ||
| ConditionVirtualization=microsoft |
Member
There was a problem hiding this comment.
This looks fine to me, although it does differ from the patch we're carrying in Fedora in that it's not a triggering conditional.
@cjp256 do you still feel that it should be a triggering conditional? In my opinion, it's just as easy to systemctl --edit --full waagent.service as it is to drop in an additional triggering conditional, but I've not thought hard about it.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
WALinuxAgent is Azure specific and Azure runs on Hyper-V. Add
ConditionVirtualization=microsoft
to service files to avoid starting WALA in other environments. In particular, this avoids polluting the console when the
same image is used both for Azure and some other env (e.g. local QEMU).
PR information
developbranch.Quality of Code and Contribution Guidelines