Disable signature validation if timeout period exceeded#3572
Open
mgunnala wants to merge 4 commits intoAzure:developfrom
Open
Disable signature validation if timeout period exceeded#3572mgunnala wants to merge 4 commits intoAzure:developfrom
mgunnala wants to merge 4 commits intoAzure:developfrom
Conversation
mgunnala
requested review from
ZhidongPeng,
maddieford,
nagworld9 and
narrieta
as code owners
narrieta
reviewed
Mar 18, 2026
| if not ignore_signature_validation_errors: | ||
| cleanup_package_with_invalid_signature(package_file) | ||
| raise | ||
| if isinstance(ex, SignatureValidationTimeoutError): |
Member
There was a problem hiding this comment.
this probably should be done before the check at 1471
| # validation errors should not be ignored, otherwise report the error and continue. | ||
| if not ignore_signature_validation_errors: | ||
| raise # Package has already been cleaned up | ||
| if isinstance(ex, SignatureValidationTimeoutError): |
Member
There was a problem hiding this comment.
We are duplicating too much logic for the existing/downloaded extension package. I don't recall: what was the motivation for doing the signature validation as part of self.protocol.client.download_zip_package and not here?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Issue #
To avoid impacting customers during telemetry release, the signature validation feature should be disabled if a certain timeout period is exceeded (10 seconds, by default).
PR information
developbranch.Quality of Code and Contribution Guidelines
Distro maintenance information, if applicable