Adjust discriminator to reduce duplicated props

[AllyW]

tsp model:

@doc("Resource configuration instance for a Flex Consumption based Azure Function App.")
model FunctionFlexConsumptionResourceConfiguration {
@doc("Memory size of the instance. Supported values are 2048, 4096.")
instanceMemoryMB: int64;

@doc("HTTP Concurrency for the function app.")
httpConcurrency?: int64;
}


@doc("Configurations of a target resource. This varies with the kind of resource.")
@discriminator("kind")
model TargetResourceConfigurations {
  @doc("Kind of the resource for which the configurations apply.")
  @visibility(Lifecycle.Create, Lifecycle.Read)
  kind: ResourceKind;
}

@doc("Configurations for a Function App using Flex Consumption Plan.")
model FunctionFlexConsumptionTargetResourceConfigurations
  extends TargetResourceConfigurations {
  @doc("""
    The kind value to use when providing configuration.
    This should typically be not changed from its value.
    """)
  kind: ResourceKind.FunctionsFlexConsumption;

  @doc("A map of configurations for a Function app using Flex Consumption Plan.")
  configurations?: Record<FunctionFlexConsumptionResourceConfiguration>;
}

output:

{
    "type": "object",
    "discriminators": [
        {
            "property": "kind",
            "value": "FunctionsFlexConsumption",
            "props": [
                {
                    "type": "object",
                    "additionalProps": {
                        "item": {
                            "type": "object",
                            "props": [
                                {
                                    "type": "integer64",
                                    "name": "instanceMemoryMB",
                                    "description": "Memory size of the instance. Supported values are 2048, 4096.",
                                    "required": true
                                },
                                {
                                    "type": "integer64",
                                    "name": "httpConcurrency",
                                    "description": "HTTP Concurrency for the function app."
                                }
                            ]
                        }
                    },
                    "name": "configurations",
                    "description": "A map of configurations for a Function app using Flex Consumption Plan."
                }
            ]
        }
    ],
    "props": [
        {
            "type": "string",
            "enum": {
                "items": [
                    {
                        "value": "FunctionsFlexConsumption"
                    }
                ]
            },
            "name": "kind",
            "description": "Kind of the resource for which the configurations apply.",
            "required": true
        }
    ],
    "name": "targetResourceConfigurations",
    "description": "Configurations of the target resource on which the test profile ran.",
    "readOnly": true
}

[kairu-ms]

why remove the discProperty varient

[AllyW]

This part adds all enums of discriminator property, by iterating through all its possible children value, however, discriminator property gets its all enums already when parsing this property using convert2CMDSchema above.

If these six lines added, then, the enums for this discriminator property would be doubled.