Skip to content

Fix some issues #507

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
necusjz merged 3 commits into from
Oct 15, 2025
Merged

Fix some issues #507

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
e81acd1
fix some issues
yanzhudd Sep 23, 2025
e38627b
Merge branch 'dev' of https://github.com/Azure/aaz-dev-tools into fix…
yanzhudd Sep 23, 2025
707062f
fix
yanzhudd Oct 15, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/aaz_dev/command/controller/command_tree.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -597,7 +597,7 @@ def verify_updated_command_tree(self):
if not group:
details[' '.join(group_names)] = {
'type': 'group',
'help': "Miss short summary."
'help': "Group not found."
}
elif not group.help or not group.help.short:
details[' '.join(group.names)] = {
Expand All @@ -610,7 +610,7 @@ def verify_updated_command_tree(self):
if not cmd:
details[' '.join(cmd_names)] = {
'type': 'command',
'help': "Miss short summary."
'help': "Command not found."
}
elif not cmd.help or not cmd.help.short:
details[' '.join(cmd.names)] = {
Expand Down
2 changes: 1 addition & 1 deletion src/aaz_dev/command/controller/workspace_manager.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1088,7 +1088,7 @@ def generate_to_aaz(self):
# Merge the commands of subresources which exported in aaz but not exist in current workspace
self._merge_sub_resources_in_aaz()

# in memory worspace folder does not support client cfg
# in memory workspace folder does not support client cfg
if not self.is_in_memory:
# update client config
editor = self.load_client_cfg_editor()
Expand Down
10 changes: 3 additions & 7 deletions src/aaz_dev/swagger/model/schema/cmd_builder.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -409,14 +409,10 @@ def build_cmd_string_format(schema):
if schema.pattern is not None:
try:
_ = re.compile(schema.pattern) # verify schema pattern
fmt.pattern = schema.pattern
fmt_assigned = True
except Exception as err:
raise exceptions.InvalidSwaggerValueError(
msg=f"Invalid regex expression",
key=[schema.traces],
value=[schema.pattern]
)
fmt.pattern = schema.pattern
fmt_assigned = True
logger.warning('Invalid regex expression: traces: {}, pattern: {}'.format(str([schema.traces]), schema.pattern))
if schema.max_length is not None:
fmt.max_length = schema.max_length
fmt_assigned = True
Expand Down