feat(purge): add --untag-limit flag to control maximum untagged manifests in purge operation #458
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ests in purge operation
ninjadq
requested review from
sajayantony,
Wwwsylvia,
shizhMSFT,
northtyphoon,
wangxiaoxuan273,
wju-MSFT and
estebanreyl
as code owners
qweeah
reviewed
Jun 16, 2025
| @@ -196,6 +196,10 @@ func GetUntaggedManifests(ctx context.Context, acrClient api.AcrCLIClientInterfa | |||
| if err != nil { | |||
| return nil, err | |||
| } | |||
| if UntagLimit > 0 && len(candidates) >= UntagLimit { | |||
| // If the number of candidates is greater than the limit, we stop fetching more manifests. | |||
| break | |||
There was a problem hiding this comment.
Breaking here means only a subset of manifest is scanned. It may cause unwanted purge since any currently dangling manifest might get referenced by a tag in the next iteration.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose of the PR
This PR will fix timeout issue when there are very large number of untagged manifest existed in repository.
Fixes #457