Skip to content

Conversation

@illume
Copy link
Collaborator

@illume illume commented Dec 29, 2025

Fixes #40

  • aks-plugin: AzureLoginPage: Use sx instead of styled
  • aks-plugin: AzureProfilePage: Use sx instead of styled
  • aks-desktop: BasicsStep: Use sx instead of styled
  • aks-desktop: Breadcrumb: Use sx instead of styled
  • aks-desktop: FormField: Use sx instead of styled
  • aks-desktop: ReviewStep: Use sx instead of styled

Testing

  • Please manually review the styles look the same/ok?

Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR refactors Material-UI components from using the styled() API to the more modern sx prop pattern across multiple components in the aks-plugin. This modernization effort simplifies the codebase by removing the need for separate styled component definitions and class name constants.

Key Changes:

  • Removed styled() API usage and replaced with inline sx prop styling
  • Eliminated PREFIX and classes constants used for CSS-in-JS class generation
  • Converted theme access from styled components to sx callback patterns

Reviewed changes

Copilot reviewed 6 out of 6 changed files in this pull request and generated 3 comments.

Show a summary per file
File Description
ReviewStep.tsx Converted styled Box to regular Box with sx props; extracted section styles to reusable variables
FormField.tsx Removed StyledInputAdornment wrapper; moved field styles directly to TextField's sx prop
Breadcrumb.tsx Replaced styled Box with sx props; added useTheme hook for accessing theme values
BasicsStep.tsx Removed styled Box wrapper; moved styles to sx props; fixed useEffect dependency array
AzureProfilePage.tsx Converted all styled components to sx props; removed extensive class definitions
AzureLoginPage.tsx Replaced styled components with sx props; extracted reusable style objects as constants

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@illume illume marked this pull request as draft December 29, 2025 13:31
@illume illume marked this pull request as ready for review December 31, 2025 00:38
yolossn
yolossn previously approved these changes Dec 31, 2025
Copy link
Member

@yolossn yolossn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@illume illume marked this pull request as draft December 31, 2025 23:39
@illume illume marked this pull request as ready for review January 5, 2026 18:19
Copilot AI review requested due to automatic review settings January 5, 2026 18:19
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 6 out of 6 changed files in this pull request and generated 2 comments.


💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 6 out of 6 changed files in this pull request and generated 1 comment.


💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 6 out of 6 changed files in this pull request and generated 4 comments.


💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 6 out of 6 changed files in this pull request and generated 3 comments.


💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 6 out of 6 changed files in this pull request and generated no new comments.


💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copy link
Collaborator

@sniok sniok left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

clicked around, looks good!

@illume illume requested a review from skoeva January 7, 2026 21:03
Copy link
Collaborator

@skoeva skoeva left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@illume illume merged commit 9d961dc into Azure:main Jan 7, 2026
7 checks passed
@illume illume deleted the styledbye branch January 7, 2026 22:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

plugins/aks-desktop: Fix components to use sx for styling

4 participants