-
Notifications
You must be signed in to change notification settings - Fork 11
aks-plugin: Convert styled usage to sx #69
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
This PR refactors Material-UI components from using the styled() API to the more modern sx prop pattern across multiple components in the aks-plugin. This modernization effort simplifies the codebase by removing the need for separate styled component definitions and class name constants.
Key Changes:
- Removed
styled()API usage and replaced with inlinesxprop styling - Eliminated PREFIX and classes constants used for CSS-in-JS class generation
- Converted theme access from styled components to sx callback patterns
Reviewed changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| ReviewStep.tsx | Converted styled Box to regular Box with sx props; extracted section styles to reusable variables |
| FormField.tsx | Removed StyledInputAdornment wrapper; moved field styles directly to TextField's sx prop |
| Breadcrumb.tsx | Replaced styled Box with sx props; added useTheme hook for accessing theme values |
| BasicsStep.tsx | Removed styled Box wrapper; moved styles to sx props; fixed useEffect dependency array |
| AzureProfilePage.tsx | Converted all styled components to sx props; removed extensive class definitions |
| AzureLoginPage.tsx | Replaced styled components with sx props; extracted reusable style objects as constants |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
plugins/aks-desktop/src/components/CreateAKSProject/components/Breadcrumb.tsx
Show resolved
Hide resolved
plugins/aks-desktop/src/components/CreateAKSProject/components/ReviewStep.tsx
Outdated
Show resolved
Hide resolved
plugins/aks-desktop/src/components/AzureAuth/AzureLoginPage.tsx
Outdated
Show resolved
Hide resolved
yolossn
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
Copilot reviewed 6 out of 6 changed files in this pull request and generated 2 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
plugins/aks-desktop/src/components/AzureAuth/AzureProfilePage.tsx
Outdated
Show resolved
Hide resolved
plugins/aks-desktop/src/components/CreateAKSProject/components/FormField.tsx
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
Copilot reviewed 6 out of 6 changed files in this pull request and generated 1 comment.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
plugins/aks-desktop/src/components/CreateAKSProject/components/BasicsStep.tsx
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
Copilot reviewed 6 out of 6 changed files in this pull request and generated 4 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
plugins/aks-desktop/src/components/AzureAuth/AzureLoginPage.tsx
Outdated
Show resolved
Hide resolved
plugins/aks-desktop/src/components/CreateAKSProject/components/Breadcrumb.tsx
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
Copilot reviewed 6 out of 6 changed files in this pull request and generated 3 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
plugins/aks-desktop/src/components/AzureAuth/AzureLoginPage.tsx
Outdated
Show resolved
Hide resolved
plugins/aks-desktop/src/components/AzureAuth/AzureProfilePage.tsx
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
Copilot reviewed 6 out of 6 changed files in this pull request and generated no new comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
sniok
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
clicked around, looks good!
skoeva
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Fixes #40
Testing