Skip to content
This repository was archived by the owner on Jan 14, 2025. It is now read-only.

Conversation

@davidgamero
Copy link
Contributor

@davidgamero davidgamero commented May 11, 2023

Description

continuing work from #79
Please include a summary of the changes and the related issue. Please also include relevant motivation and context. List any dependencies that are required for this change.

This adds the features of creating a github actions workflow through the vscode extension.
Workflow generation uses the existing pattern of wrapping the draft binary, and writes to the filesystem. Created files are opened for the user to see.

Add new dependency on git extension within vscode.

Type of change

Please delete options that are not relevant.

  • New feature (non-breaking change which adds functionality)

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration. Is it a breaking change which will impact consuming tool(s).

  • Testing extension working through properly configured Azure resources.

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

Copy link
Member

@Tatsinnit Tatsinnit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🙏 hiya, thank you for this PR. Will you be keen for some quick discussion around this Pr, I might be joining this discuss late. I am really interested to discuss end goal and perspective of this pr , reason being there is developer experience across many vscode extensions which is around aks, will be great to discuss how it fits into that kind of thinking and we should start thinking more cumulative. Thanks heaps, ❤️🙏

@davidgamero
Copy link
Contributor Author

hey @Tatsinnit , this PR is mostly updating the PR @bfoley13 had previously to match the current patterns used in the extension.
the current goal is to also add the ability to set OIDC secrets on github to enable the generated workflows to actually run as well (which is why the updates to az.ts and git client are used)
i can update the PR to better describe the purpose and goal as I recognize it is a lot of code to review
happy to discuss the goals, @qpetraroia has more perspective here too

@davidgamero davidgamero marked this pull request as ready for review May 22, 2023 15:01
OliverMKing
OliverMKing previously approved these changes May 22, 2023
@davidgamero davidgamero merged commit 5e04665 into Azure:main May 23, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants