Enhancements and Fixes in Terraform Greenfield ADDS Deployment

[sihbher]

Overview/Summary

Replace this with a brief description of what this Pull Request fixes, changes, etc.

This PR fixes/adds/changes/removes

1. Virtual Network Enhancements
   • Introduced conditional logic (use_same_hub_identity_vnet) in network/locals.tf to validate if identity_subscription_id matches hub_subscription_id.
   • Added new virtual network peering configurations (peer2, peer3, and peer4) in network/main.tf to improve connectivity.

2. Key Vault Firewall Rules Update
   • Introduced dynamic IP retrieval using https://api.ipify.org/ and https://api64.ipify.org/ to automatically allow the current public IP in Key Vault firewall rules (keyvault.tf).
   • Replaced hardcoded IP (136.28.83.128) with dynamically retrieved IP addresses.

3. AVD Resource Naming Standardization
   • Updated Azure Virtual Desktop (AVD) resource names in main.tf:
   • Removed var.avdLocation from virtual_desktop_host_pool_name and virtual_desktop_application_group_name to be compliant with name restrictions.

4. Version Upgrades for AVD Modules
   • Updated AVD workspace module version from 0.1.2 to 0.2.0 to leverage the latest Terraform features.

Testing Evidence

Replace this with any testing evidence to show that your Pull Request works/fixes as described and planned (include screenshots, if appropriate).

As part of this Pull Request I have

• Read the Contribution Guide and ensured this PR is compliant with the guide
• Ensured the resource API versions in .bicep file/s I am adding/editing are using the latest API version possible
• Checked for duplicate Pull Requests
• Associated it with relevant GitHub Issues
• (AVD LZA Team Only) Associated it with relevant ADO Items
• Ensured my code/branch is up-to-date with the latest changes in the main branch
• Performed testing and provided evidence.
• Updated relevant and associated documentation (e.g. Contribution Guide, Module READMEs, Docs etc.)