Closed
Conversation
…o match (#750) * removed Key expiration * updated Groups UI
* updates * updates * updates * updates * updates * updates * updates * updates * Added Support for EntraID identities (#754) * removed Key expiration * updated Groups UI * entraid support * removed extra if * testing with my branch * remove managementvm on entraid * update portal * updated ui * changed EnterpriseApp to ServicePrincipal * updated portal * fixed avdarm * update RBAC * updated url for script * updated ui * fixed createPrivateDNS parameter * fixed identityDomainName in SessionHost Script * added conditions for storage managed identity * added logging to set session host * changed to -command * configure baseuri back to azure * updated doc for identity info * settings * new session host brownfield fix up * merged files * updated json files * fixed reference to sub * fixed hostpool call * updated reference * fixed portalui for new session hosts * fixed validation on deployment prefix * fixed regex * tag regex * fixed modulo function and portal * fixed portal screen * update set-sessionhostconfig.ps1 * update allowed values for tags * updated batch size * unified changes across baseline and new session hosts * fixed keyvault ref * added index to UI * updated publisher reference for all lowercase * added count to UI * fixed vmsize count reference * fixed custom image in portal ui * updated docs and reverted script path to azure repo * fixed the servicePrincpalApiCalls * fixed condition on serviceprincipal blade controls and outputs. * updated to match azure repo in leue of sync * Update deploy.bicep --------- Co-authored-by: Dany Contreras <78437433+danycontre@users.noreply.github.com> * updates * updates * fixed the filtering and added condition for info box on manageement pane. * fixed filter on sku * updated branch name for tests * added filter for SKU * added Service Principal to Role Assignment * added ServicePrincipal to Role Assignment * changed avdEnterpriseAppId to avdServicePrincipalId * changed branch * update doc * updated share path creation in configureSessionHost.bicep * fixed filesharepath for fslogix * updates * updates * updates * updates * updates * updates * updates * updated new session host portal ui * added filtering for storage Account * allowed descrption on storage account * updates * updates * added new add-on for storage account key rotation * updates * renamed file * fixed file name * improved resource group drop down to show only those with cm-resource-parent tags and show value of hostPool Name to help in selection process * have to disable roaming the recycle bin to prevent corruption of recycle bin with cloud only identities * fixed key path * fixed minor bug in set sessionhost script * updates to api * fixed loop variable * removed bold on Resource Group * fixed set-registryValue error * updated name of deployments * update batch deployment name * updated parameter on Set-RegistryValue call for Entra ID * updated deployment names to increment batchid + 1 * updated logging * fixed parameter on write-log calls * added local group membership for fslogix * added garbage collection to hkcu unload * added error catching * retrieved deppref and environment from rg name * updates * reverting commit * reverting commit * reverted commit * DesktopVirtualization AVM API Version Update for US Gov Support * updated desktopvirtualization application avm api version * updated more modules with gov api version * avm update for subnets and privatednszones * regenerate arm * updated hostpool api version everywhere * fixed appid to search on portal-ui * updated graphapi filter * fixed bug in disk encryption section of UI * PR merge updates * PR merge updates * PR merge updates * PR merge updates * PR merge updates * PR merge updates * PR merge updates * PR merge updates * PR merge updates * PR merge updates --------- Co-authored-by: Dany Contreras <dany.contreras@microsoft.com> Co-authored-by: Shawn Meyer <49066369+shawntmeyer@users.noreply.github.com> Co-authored-by: Shawn Meyer <shmeyer@microsoft.com>
Enhancements and Fixes in Terraform Greenfield ADDS Deployment
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
workload/arm/brownfield/deployUpdateFSLogixStorageAccountKeyOnHosts.json
Dismissed
Show dismissed
Hide dismissed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview/Summary
Replace this with a brief description of what this Pull Request fixes, changes, etc.
This PR fixes/adds/changes/removes
Breaking Changes
Testing Evidence
Replace this with any testing evidence to show that your Pull Request works/fixes as described and planned (include screenshots, if appropriate).
As part of this Pull Request I have
.bicepfile/s I am adding/editing are using the latest API version possiblemainbranch