fix: Resolve CI linting failures

- Fix undefined variables (update_containerapp_from_compose, ContainerAppClient)
- Remove 322 trailing whitespace errors across all Python files
- Fix 4 unused variable warnings (models_app, models_list, gateway_url)
- Convert f-strings without placeholders to regular strings
- Fix PEP8 formatting (spacing, indentation, blank lines)

Addresses CI test failures from PR #9422 review feedback.

Author: Simon Jakesch

src/containerapp/azext_containerapp/_compose_utils.py

@@ -1,19 +1,19 @@
-# --------------------------------------------------------------------------------------------
-# Copyright (c) Microsoft Corporation. All rights reserved.
-# Licensed under the MIT License. See License.txt in the project root for license information.
-# --------------------------------------------------------------------------------------------
-
-from flask import Flask
-from datetime import datetime
-from flask import current_app
-
-app = Flask(__name__)
-
-@app.route("/")
-def hello():
-    return "Hello World! " + str(datetime.now())
-
-@app.route("/applicationpath")
-def applicationPath():
-    return current_app.root_path
-
+# --------------------------------------------------------------------------------------------
+# Copyright (c) Microsoft Corporation. All rights reserved.
+# Licensed under the MIT License. See License.txt in the project root for license information.
+# --------------------------------------------------------------------------------------------
+
+from flask import Flask
+from datetime import datetime
+from flask import current_app
+
+app = Flask(__name__)
+
+@app.route("/")
+def hello():
+    return "Hello World! " + str(datetime.now())
+
+@app.route("/applicationpath")
+def applicationPath():
+    return current_app.root_path
+

src/containerapp/azext_containerapp/_validators.py

@@ -29,7 +29,7 @@ def test_containerapp_blob_storage_token_store_msi(self, resource_group):
 
         env = prepare_containerapp_env_for_app_e2e_tests(self, location)
         self.cmd('containerapp create -g {} -n {} --environment {} --image mcr.microsoft.com/k8se/quickstart:latest --ingress external --target-port 80 --system-assigned --user-assigned {}'.format(resource_group, app, env, user_identity_name))
-        
+
         client_id = 'c0d23eb5-ea9f-4a4d-9519-bfa0a422c491'
         client_secret = 'c0d23eb5-ea9f-4a4d-9519-bfa0a422c491'
         issuer = 'https://sts.windows.net/54826b22-38d6-4fb2-bad9-b7983a3e9c5a/'
@@ -43,15 +43,15 @@ def test_containerapp_blob_storage_token_store_msi(self, resource_group):
                               "microsoft-provider-authentication-secret"),
                 JMESPathCheck('registration.openIdIssuer', issuer),
             ])
-        
+
         self.cmd(
             'containerapp auth update  -g {} -n {} --token-store true --blob-container-uri {} --yes'
             .format(resource_group, app, blobContainerUri), checks=[
                 JMESPathCheck('properties.login.tokenStore.enabled', True),
                 JMESPathCheck('properties.login.tokenStore.azureBlobStorage.blobContainerUri', blobContainerUri),
                 JMESPathCheckNotExists('properties.login.tokenStore.azureBlobStorage.managedIdentityResourceId'),
             ])
-        
+
         self.cmd(
             'containerapp auth update -g {} -n {} --token-store true --blob-container-uri {} --blob-container-identity {}'
             .format(resource_group, app, blobContainerUri, user_identity_id), checks=[

src/containerapp/azext_containerapp/custom.py

@@ -325,13 +325,13 @@ def test_containerapp_ingress_traffic_labels_e2e(self, resource_group):
         self.cmd('containerapp update -g {} -n {} --cpu 1.0 --memory 2Gi --target-label label2'.format(resource_group, ca_name))
 
         # it may take a minute for the new revision to be created and added to traffic.
-        traffic = self.cmd('containerapp ingress traffic show -g {} -n {}'.format(resource_group, ca_name)).get_output_in_json()    
+        traffic = self.cmd('containerapp ingress traffic show -g {} -n {}'.format(resource_group, ca_name)).get_output_in_json()
         for _ in range(100):
             if len(traffic) >= 2:
                 break
             time.sleep(5)
             traffic = self.cmd('containerapp ingress traffic show -g {} -n {}'.format(resource_group, ca_name)).get_output_in_json()
-        
+
         self.assertEqual(len(traffic), 2)
 
         revisions_list = self.cmd('containerapp revision list -g {} -n {}'.format(resource_group, ca_name)).get_output_in_json()
@@ -1636,7 +1636,7 @@ def test_containerapp_update_mode_e2e(self, resource_group):
 
         self.cmd(f"containerapp create -g {resource_group} -n {ca_name} --environment {env} --image mcr.microsoft.com/k8se/quickstart:latest --ingress external --target-port 80",
                  checks=[
-                    JMESPathCheck('properties.configuration.activeRevisionsMode', "Single"),                     
+                    JMESPathCheck('properties.configuration.activeRevisionsMode', "Single"),
                  ])
 
         try:

src/containerapp/azext_containerapp/tests/latest/data/source_built_using_bullseye_buildpack_python310/app.py

@@ -70,7 +70,7 @@ def test_containerapp_compose_with_command_list(self, resource_group):
             'environment': env_id,
             'compose': compose_file_name,
         })
-        
+
         command_string = 'containerapp compose create'
         command_string += ' --compose-file-path {compose}'
         command_string += ' --resource-group {rg}'

src/containerapp/azext_containerapp/tests/latest/test_containerapp_auth_commands.py

@@ -76,7 +76,7 @@ def test_containerapp_compose_create_with_environment_prompt(self, resource_grou
             'environment': env_id,
             'compose': compose_file_name,
         })
-        
+
         command_string = 'containerapp compose create'
         command_string += ' --compose-file-path {compose}'
         command_string += ' --resource-group {rg}'

src/containerapp/azext_containerapp/tests/latest/test_containerapp_commands.py

@@ -139,7 +139,7 @@ def test_containerapp_compose_create_with_ingress_prompt(self, resource_group):
             'environment': env_id,
             'compose': compose_file_name,
         })
-        
+
         command_string = 'containerapp compose create'
         command_string += ' --compose-file-path {compose}'
         command_string += ' --resource-group {rg}'

src/containerapp/azext_containerapp/tests/latest/test_containerapp_compose_command.py

@@ -25,9 +25,9 @@ class ContainerAppComposeMCPGatewayScenarioTest(ScenarioTest):
     def test_mcp_gateway_deployment(self, resource_group):
         """
         Test US2 Acceptance Scenario 1: Deploy compose file with MCP gateway.
-        
+
         Expected: MCP gateway service is created without being assigned to GPU profile.
-        
+
         This test MUST FAIL until T032-T043 are implemented.
         """
         self.kwargs.update({
@@ -53,9 +53,9 @@ def test_mcp_gateway_deployment(self, resource_group):
     def test_managed_identity_enablement(self, resource_group):
         """
         Test US2 Acceptance Scenario 2: System-assigned managed identity enabled for MCP gateway.
-        
+
         Expected: MCP gateway container app has system-assigned managed identity enabled.
-        
+
         This test MUST FAIL until T034-T037 are implemented.
         """
         self.kwargs.update({
@@ -78,9 +78,9 @@ def test_managed_identity_enablement(self, resource_group):
     def test_role_assignment(self, resource_group):
         """
         Test US2 Acceptance Scenario 3: Azure AI Developer role assigned to MCP gateway identity.
-        
+
         Expected: MCP gateway managed identity has "Azure AI Developer" role on resource group.
-        
+
         This test MUST FAIL until T038-T043 are implemented.
         """
         self.kwargs.update({
@@ -105,9 +105,9 @@ def test_role_assignment(self, resource_group):
     def test_mcp_environment_injection(self, resource_group):
         """
         Test US2 Acceptance Scenario 4: Environment variable injection for MCP gateway dependencies.
-        
+
         Expected: Services that depend on MCP gateway receive MCP_ENDPOINT environment variable.
-        
+
         This test MUST FAIL until T040-T043 are implemented.
         """
         self.kwargs.update({
@@ -122,6 +122,6 @@ def test_mcp_environment_injection(self, resource_group):
         # Check web service has MCP_ENDPOINT
         web_app = self.cmd('containerapp show -g {rg} -n web').get_output_in_json()
         env_vars = {e['name']: e.get('value', '') for e in web_app['properties']['template']['containers'][0].get('env', [])}
-        
+
         self.assertIn('MCP_ENDPOINT', env_vars)
         self.assertIn('mcp-gateway', env_vars['MCP_ENDPOINT'].lower())