Skip to content

fix azconnectedk8s update --disable-proxy#8212

Closed
dimbleby wants to merge 1 commit intoAzure:mainfrom
dimbleby:disable-proxy
Closed

fix azconnectedk8s update --disable-proxy#8212
dimbleby wants to merge 1 commit intoAzure:mainfrom
dimbleby:disable-proxy

Conversation

@dimbleby
Copy link
Member

pass empty "proxy" settings to cluster config DP, which will understand that to mean that proxy is being disabled.

cf https://msazure.visualstudio.com/One/_git/compute-HybridMgmt-ClusterConfigDP/pullrequest/11170292

@bavneetsingh16

This checklist is used to make sure that common guidelines for a pull request are followed.

Related command

General Guidelines

  • Have you run azdev style <YOUR_EXT> locally? (pip install azdev required)
  • Have you run python scripts/ci/test_index.py -q locally? (pip install wheel==0.30.0 required)
  • My extension version conforms to the Extension version schema

For new extensions:

About Extension Publish

There is a pipeline to automatically build, upload and publish extension wheels.
Once your pull request is merged into main branch, a new pull request will be created to update src/index.json automatically.
You only need to update the version information in file setup.py and historical information in file HISTORY.rst in your PR but do not modify src/index.json.

pass empty "proxy" settings to cluster config DP, which will understand
that to mean that proxy is being disabled.
@azure-client-tools-bot-prd
Copy link

azure-client-tools-bot-prd bot commented Oct 30, 2024

️✔️Azure CLI Extensions Breaking Change Test
️✔️Non Breaking Changes

@azure-client-tools-bot-prd
Copy link

Hi @dimbleby,
Please write the description of changes which can be perceived by customers into HISTORY.rst.
If you want to release a new extension version, please update the version in setup.py as well.

@azure-client-tools-bot-prd
Copy link

Hi @dimbleby,
Since the current milestone time is less than 7 days, this pr will be reviewed in the next milestone.

@yonzhan
Copy link
Collaborator

yonzhan commented Oct 30, 2024

Thank you for your contribution! We will review the pull request and get back to you soon.

@github-actions
Copy link

Hi @dimbleby

Release Suggestions

Module: connectedk8s

  • Please log updates into to src/connectedk8s/HISTORY.rst
  • Update VERSION to 1.10.1 in src/connectedk8s/setup.py

Notes

@dimbleby dimbleby closed this Oct 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants