Skip to content

Conversation

@mbhardwaj-msft
Copy link
Contributor

@mbhardwaj-msft mbhardwaj-msft commented Nov 13, 2024


This checklist is used to make sure that common guidelines for a pull request are followed.

Related command

General Guidelines

  • Have you run azdev style <YOUR_EXT> locally? (pip install azdev required)
  • Have you run python scripts/ci/test_index.py -q locally? (pip install wheel==0.30.0 required)
  • My extension version conforms to the Extension version schema

For new extensions:

About Extension Publish

There is a pipeline to automatically build, upload and publish extension wheels.
Once your pull request is merged into main branch, a new pull request will be created to update src/index.json automatically.
You only need to update the version information in file setup.py and historical information in file HISTORY.rst in your PR but do not modify src/index.json.

@azure-client-tools-bot-prd
Copy link

azure-client-tools-bot-prd bot commented Nov 13, 2024

⚠️Azure CLI Extensions Breaking Change Test
⚠️load
rule cmd_name rule_message suggest_message
⚠️ 1006 - ParaAdd load test create cmd load test create added parameter autostop_error_rate_time_window
⚠️ 1006 - ParaAdd load test create cmd load test create added parameter autostop_error_rate
⚠️ 1006 - ParaAdd load test create cmd load test create added parameter autostop
⚠️ 1006 - ParaAdd load test update cmd load test update added parameter autostop_error_rate_time_window
⚠️ 1006 - ParaAdd load test update cmd load test update added parameter autostop_error_rate
⚠️ 1006 - ParaAdd load test update cmd load test update added parameter autostop

@azure-client-tools-bot-prd
Copy link

Hi @mbhardwaj-msft,
Since the current milestone time is less than 7 days, this pr may not catch up with this release.

@azure-client-tools-bot-prd
Copy link

Hi @mbhardwaj-msft,
Please write the description of changes which can be perceived by customers into HISTORY.rst.
If you want to release a new extension version, please update the version in setup.py as well.

@yonzhan
Copy link
Collaborator

yonzhan commented Nov 13, 2024

Thank you for your contribution! We will review the pull request and get back to you soon.

@github-actions
Copy link

CodeGen Tools Feedback Collection

Thank you for using our CodeGen tool. We value your feedback, and we would like to know how we can improve our product. Please take a few minutes to fill our codegen survey

@github-actions
Copy link

@mbhardwaj-msft mbhardwaj-msft marked this pull request as ready for review November 18, 2024 05:31
@kairu-ms
Copy link
Contributor

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 2 pipeline(s).

Copy link

@sulabh-msft sulabh-msft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Left few minor comments.

@yonzhan
Copy link
Collaborator

yonzhan commented Nov 23, 2024

Please fix CI issues

@kairu-ms kairu-ms merged commit 7159946 into Azure:main Nov 26, 2024
21 checks passed
@azclibot
Copy link
Collaborator

[Release] Update index.json for extension [ load ] : https://dev.azure.com/msazure/One/_build/results?buildId=109030370&view=results

ksayid pushed a commit to SethHollandsworth/azure-cli-extensions that referenced this pull request Jan 8, 2025
* [az][load] support for autostop criteria

* fix logger warning

* fix recordings

* action on comments

* pylint

* action on comments

* action on comments

* fix azdev linter
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants