[cosmosdb-preview] Add support for Table RBAC role definition and assignment CRUD actions #8310

etcriss · 2024-11-22T19:39:09Z

This checklist is used to make sure that common guidelines for a pull request are followed.

Related command

General Guidelines

Have you run azdev style <YOUR_EXT> locally? (pip install azdev required)
Have you run python scripts/ci/test_index.py -q locally? (pip install wheel==0.30.0 required)
My extension version conforms to the Extension version schema

For new extensions:

My extension description/summary conforms to the Extension Summary Guidelines.

About Extension Publish

There is a pipeline to automatically build, upload and publish extension wheels.
Once your pull request is merged into main branch, a new pull request will be created to update src/index.json automatically.
You only need to update the version information in file setup.py and historical information in file HISTORY.rst in your PR but do not modify src/index.json.

azure-client-tools-bot-prd · 2024-11-22T19:39:12Z

Hi @etcriss,
Please write the description of changes which can be perceived by customers into HISTORY.rst.
If you want to release a new extension version, please update the version in setup.py as well.

azure-client-tools-bot-prd · 2024-11-22T19:39:15Z

⚠️Azure CLI Extensions Breaking Change Test

⚠️cosmosdb-preview

rule cmd_name rule_message suggest_message

⚠️ 1011 - SubgroupAdd cosmosdb table role sub group cosmosdb table role added

yonzhan · 2024-11-22T19:39:21Z

Thank you for your contribution! We will review the pull request and get back to you soon.

github-actions · 2024-11-22T19:43:46Z

For more info about extension versioning, please refer to Extension version schema

AllyW · 2024-11-26T05:28:35Z

src/cosmosdb-preview/setup.py

 # TODO: Confirm this is the right version number you want and it matches your
 # HISTORY.rst entry.
-VERSION = '1.1.0b1'
+VERSION = '1.2.0'


Stable version after 1.1.0b1 is 1.1.0.

evelyn-ys · 2025-01-17T08:08:52Z

...-preview/azext_cosmosdb_preview/tests/latest/test_cosmosdb_table_rbac_assignment_scenario.py

+        builtin_role_def_id_full = '/subscriptions/80be3961-0521-4a0a-8570-5cd5a4e2f98c/resourceGroups/cli_test_cosmosdb_table_role_assignmentu4ss2n535bbvhe2wmufck5yfhyziujp77gg4/providers/Microsoft.DocumentDB/databaseAccounts/clikznzrccyiwbv/tableRoleDefinitions/00000000-0000-0000-0000-000000000001'
+
+        builtin_role_def_id_full_update = '/subscriptions/80be3961-0521-4a0a-8570-5cd5a4e2f98c/resourceGroups/cli_test_cosmosdb_table_role_assignmentu4ss2n535bbvhe2wmufck5yfhyziujp77gg4/providers/Microsoft.DocumentDB/databaseAccounts/clikznzrccyiwbv/tableRoleDefinitions/00000000-0000-0000-0000-000000000002'


Can you avoid use fixed resource? Is it possible to create a role definition within test?

This is following the precedent set by the existing implementation and tests for the sql version of this feature. We'd like both test frameworks to do the exact same thing if possible to confirm compatibility and functionality matches between the two implementations.

evelyn-ys · 2025-01-20T01:43:08Z

/azp run

azure-pipelines · 2025-01-20T01:43:20Z

Azure Pipelines successfully started running 2 pipeline(s).

etcriss · 2025-02-21T14:43:44Z

I have pulled and updated to the latest version of the cli dev branch, rerun 'azdev setup --cli D:\repos\azure-cli --repo D:\repos\etcriss\azure-cli-extensions -e cosmosdb-preview', rerun the tests successfully, and rerecorded the results of those tests.

What are the next steps to getting these changes verified and checked in?

yonzhan · 2025-02-21T23:38:57Z

Please fix conflicts

evelyn-ys · 2025-02-25T03:25:32Z

/azp run

azure-pipelines · 2025-02-25T03:25:44Z

Azure Pipelines successfully started running 2 pipeline(s).

evelyn-ys · 2025-02-25T03:53:21Z

src/cosmosdb-preview/HISTORY.rst

-
 Release History
 ===============
+1.3.0


Suggested change

1.3.0

1.2.0

…wers

evelyn-ys · 2025-02-26T08:04:58Z

/azp run

azure-pipelines · 2025-02-26T08:05:11Z

Azure Pipelines successfully started running 2 pipeline(s).

azclibot · 2025-02-26T08:27:48Z

[Release] Update index.json for extension [ cosmosdb-preview-1.2.0 ] : https://dev.azure.com/msazure/One/_build/results?buildId=116286928&view=results

etcriss added 2 commits November 22, 2024 10:08

Updating cosmosdb_preview for 12.01 preview release cli

8dd374b

Adding remaining changes from documentation to bump version

f714c45

microsoft-github-policy-service bot added the customer-reported Issues that are reported by GitHub users external to the Azure organization. label Nov 22, 2024

github-actions bot added the release-version-block Updates do not qualify release version rules. NOTE: please do not edit it manually. label Nov 22, 2024

yonzhan requested review from calvinhzy and evelyn-ys November 23, 2024 01:48

yonzhan assigned evelyn-ys Nov 23, 2024

yonzhan added this to the Backlog milestone Nov 23, 2024

AllyW reviewed Nov 26, 2024

View reviewed changes

AllyW added the stable release extension module as stable label Nov 26, 2024

etcriss added 13 commits November 26, 2024 18:13

working table api role definition tests

ef93ad7

Working table role assignment tests

fe19ad9

Cleaning up new resources and removing debugging helpers

88c3c52

removing unused validator

88f7c5c

Adding help updates

02ad50e

Fixing help

3200803

Trying to fix param help

4bd825b

Trying to fix param help

5e0eb31

Trying to fix param help

49139e8

Trying to fix param help

4c739b9

Trying to fix param help

d8229c0

Fixing version

f4ea516

Removing azext.isPreview: true, as requested by github-actions bot

7a41208

github-actions bot removed the release-version-block Updates do not qualify release version rules. NOTE: please do not edit it manually. label Jan 15, 2025

AllyW approved these changes Jan 16, 2025

View reviewed changes

evelyn-ys reviewed Jan 17, 2025

View reviewed changes

Updating and rerecording tests with latest cli dev branch

97a8c35

github-actions bot added the release-version-block Updates do not qualify release version rules. NOTE: please do not edit it manually. label Feb 21, 2025

updating version to 1.2.0

8983eec

github-actions bot removed the release-version-block Updates do not qualify release version rules. NOTE: please do not edit it manually. label Feb 21, 2025

Resolving merge conflicts

df0824f

github-actions bot added the release-version-block Updates do not qualify release version rules. NOTE: please do not edit it manually. label Feb 24, 2025

Changing version to be 1.2.0 as requested by github actions bot

ef09286

github-actions bot removed the release-version-block Updates do not qualify release version rules. NOTE: please do not edit it manually. label Feb 24, 2025

evelyn-ys reviewed Feb 25, 2025

View reviewed changes

src/cosmosdb-preview/HISTORY.rst Outdated

Release History

===============

1.3.0

Copy link

Member

evelyn-ys Feb 25, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change

1.3.0

1.2.0

Chaning history.rst version from 1.3.0 to 1.2.0 as requested by revie…

79fff8e

…wers

evelyn-ys changed the title ~~User/etcriss/cdb tableapi aad suppport/cli role commands~~ [cosmosdb-preview] Add support for Table RBAC role definition and assignment CRUD actions Feb 26, 2025

evelyn-ys approved these changes Feb 26, 2025

View reviewed changes

evelyn-ys merged commit bec1e15 into Azure:main Feb 26, 2025
21 of 22 checks passed

		builtin_role_def_id_full = '/subscriptions/80be3961-0521-4a0a-8570-5cd5a4e2f98c/resourceGroups/cli_test_cosmosdb_table_role_assignmentu4ss2n535bbvhe2wmufck5yfhyziujp77gg4/providers/Microsoft.DocumentDB/databaseAccounts/clikznzrccyiwbv/tableRoleDefinitions/00000000-0000-0000-0000-000000000001'

		builtin_role_def_id_full_update = '/subscriptions/80be3961-0521-4a0a-8570-5cd5a4e2f98c/resourceGroups/cli_test_cosmosdb_table_role_assignmentu4ss2n535bbvhe2wmufck5yfhyziujp77gg4/providers/Microsoft.DocumentDB/databaseAccounts/clikznzrccyiwbv/tableRoleDefinitions/00000000-0000-0000-0000-000000000002'

[cosmosdb-preview] Add support for Table RBAC role definition and assignment CRUD actions #8310

[cosmosdb-preview] Add support for Table RBAC role definition and assignment CRUD actions #8310

Uh oh!

Conversation

etcriss commented Nov 22, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Related command

General Guidelines

About Extension Publish

Uh oh!

azure-client-tools-bot-prd bot commented Nov 22, 2024

Uh oh!

azure-client-tools-bot-prd bot commented Nov 22, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

yonzhan commented Nov 22, 2024

Uh oh!

github-actions bot commented Nov 22, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

AllyW Nov 26, 2024

Choose a reason for hiding this comment

Uh oh!

evelyn-ys Jan 17, 2025

Choose a reason for hiding this comment

Uh oh!

etcriss Feb 21, 2025

Choose a reason for hiding this comment

Uh oh!

evelyn-ys commented Jan 20, 2025

Uh oh!

azure-pipelines bot commented Jan 20, 2025

Uh oh!

etcriss commented Feb 21, 2025

Uh oh!

yonzhan commented Feb 21, 2025

Uh oh!

evelyn-ys commented Feb 25, 2025

Uh oh!

azure-pipelines bot commented Feb 25, 2025

Uh oh!

evelyn-ys Feb 25, 2025

Choose a reason for hiding this comment

Uh oh!

evelyn-ys commented Feb 26, 2025

Uh oh!

azure-pipelines bot commented Feb 26, 2025

Uh oh!

Uh oh!

azclibot commented Feb 26, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

etcriss commented Nov 22, 2024 •

edited

Loading

azure-client-tools-bot-prd bot commented Nov 22, 2024 •

edited

Loading

github-actions bot commented Nov 22, 2024 •

edited

Loading