Skip to content

Change to new azurearcdata whl link#8354

Open
ranishan wants to merge 2 commits intoAzure:mainfrom
ranishan:dev/ranishan/changelink
Open

Change to new azurearcdata whl link#8354
ranishan wants to merge 2 commits intoAzure:mainfrom
ranishan:dev/ranishan/changelink

Conversation

@ranishan
Copy link

@ranishan ranishan commented Dec 2, 2024


Description

Update links to arcdata whl files as we are moving the files to a different location with the motive to remove the old locations.

Related command

az extension add --name arcdata

General Guidelines

  • Have you run azdev style <YOUR_EXT> locally? (pip install azdev required)
  • Have you run python scripts/ci/test_index.py -q locally? (pip install wheel==0.30.0 required)
  • My extension version conforms to the Extension version schema

For new extensions:

About Extension Publish

There is a pipeline to automatically build, upload and publish extension wheels.
Once your pull request is merged into main branch, a new pull request will be created to update src/index.json automatically.
You only need to update the version information in file setup.py and historical information in file HISTORY.rst in your PR but do not modify src/index.json.

@azure-client-tools-bot-prd
Copy link

azure-client-tools-bot-prd bot commented Dec 2, 2024

️✔️Azure CLI Extensions Breaking Change Test
️✔️Non Breaking Changes

@azure-client-tools-bot-prd
Copy link

Hi @ranishan,
Please write the description of changes which can be perceived by customers into HISTORY.rst.
If you want to release a new extension version, please update the version in setup.py as well.

@yonzhan
Copy link
Collaborator

yonzhan commented Dec 2, 2024

Thank you for your contribution! We will review the pull request and get back to you soon.

@github-actions
Copy link
Contributor

github-actions bot commented Dec 2, 2024

🚫All pull requests will be blocked to merge until Jan 6, 2025 due to CCOA

@github-actions
Copy link
Contributor

github-actions bot commented Dec 2, 2024

@github-actions
Copy link
Contributor

github-actions bot commented Dec 2, 2024

CodeGen Tools Feedback Collection

Thank you for using our CodeGen tool. We value your feedback, and we would like to know how we can improve our product. Please take a few minutes to fill our codegen survey

Copy link
Contributor

@swells swells left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We need to double check with @kairu-ms//@yonzhan /team if updating these vcr recoding's are ok like this since all we ae doing is moving storage endpoint uri or do these get automatically generated for us once we change the index.json

@kairu-ms
Copy link
Contributor

kairu-ms commented Dec 6, 2024

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 2 pipeline(s).

@kairu-ms
Copy link
Contributor

kairu-ms commented Dec 6, 2024

We need to double check with @kairu-ms//@yonzhan /team if updating these vcr recoding's are ok like this since all we ae doing is moving storage endpoint uri or do these get automatically generated for us once we change the index.json

Yes, that's fine, but no need to change the recording files.BTW, because of CCOA, I will not merge it right now.

@kairu-ms
Copy link
Contributor

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 2 pipeline(s).

@necusjz
Copy link
Member

necusjz commented Jan 19, 2025

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 2 pipeline(s).

@ranishan
Copy link
Author

Closing PR in favor of #8434 which has the required changes.

@ranishan ranishan closed this Jan 23, 2025
@swells swells reopened this Feb 4, 2025
@swells swells requested a review from Juliehzl as a code owner February 4, 2025 22:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants