Skip to content

Conversation

@bavneetsingh16
Copy link
Contributor


This checklist is used to make sure that common guidelines for a pull request are followed.

Related command

General Guidelines

  • Have you run azdev style <YOUR_EXT> locally? (pip install azdev required)
  • Have you run python scripts/ci/test_index.py -q locally? (pip install wheel==0.30.0 required)
  • My extension version conforms to the Extension version schema

For new extensions:

About Extension Publish

There is a pipeline to automatically build, upload and publish extension wheels.
Once your pull request is merged into main branch, a new pull request will be created to update src/index.json automatically.
You only need to update the version information in file setup.py and historical information in file HISTORY.rst in your PR but do not modify src/index.json.

Bavneet Singh and others added 30 commits November 22, 2024 09:02
* ruff fix

* remove duplicate code block

* cleaner fix for no existing kubeconfig

makes the type annotations true again
Add Kubectl Check to Proxy Test
…rror

add telemetry for helm install error
@azure-client-tools-bot-prd
Copy link

azure-client-tools-bot-prd bot commented Feb 5, 2025

️✔️Azure CLI Extensions Breaking Change Test
️✔️Non Breaking Changes

@azure-client-tools-bot-prd
Copy link

Hi @bavneetsingh16,
Since the current milestone time is less than 7 days, this pr will be reviewed in the next milestone.

@bavneetsingh16 bavneetsingh16 marked this pull request as draft February 5, 2025 21:57
@yonzhan
Copy link
Collaborator

yonzhan commented Feb 5, 2025

Thank you for your contribution! We will review the pull request and get back to you soon.

@github-actions
Copy link

github-actions bot commented Feb 5, 2025

The git hooks are available for azure-cli and azure-cli-extensions repos. They could help you run required checks before creating the PR.

Please sync the latest code with latest dev branch (for azure-cli) or main branch (for azure-cli-extensions).
After that please run the following commands to enable git hooks:

pip install azdev --upgrade
azdev setup -c <your azure-cli repo path> -r <your azure-cli-extensions repo path>

@github-actions
Copy link

github-actions bot commented Feb 5, 2025

@bavneetsingh16
Copy link
Contributor Author

bavneetsingh16 commented Feb 6, 2025

We have set up live tests in our forked repository as a continuous integration (CI) check and those tests include coverage for all these changes. All the tests can be found here: https://github.com/AzureArcForKubernetes/connectedk8s/blob/main/testing/test/configurations

As the code owners of this extension CLI, we mandate that all changes be first made in our forked repository to ensure they undergo our comprehensive test suite

@bavneetsingh16 bavneetsingh16 marked this pull request as ready for review February 6, 2025 05:13
@zhoxing-ms zhoxing-ms merged commit aa7431b into Azure:main Feb 6, 2025
30 of 32 checks passed
@azclibot
Copy link
Collaborator

azclibot commented Feb 6, 2025

[Release] Update index.json for extension [ connectedk8s-1.10.5 ] : https://dev.azure.com/msazure/One/_build/results?buildId=114449774&view=results

Jenniferyingni pushed a commit to Jenniferyingni/azure-cli-extensions that referenced this pull request Feb 9, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants