Skip to content

Conversation

@clnv
Copy link
Contributor

@clnv clnv commented Feb 6, 2025


This checklist is used to make sure that common guidelines for a pull request are followed.

Related command

  • az aks create
  • az aks nodepool add

refer: Azure/azure-cli#30768

General Guidelines

  • Have you run azdev style <YOUR_EXT> locally? (pip install azdev required)
  • Have you run python scripts/ci/test_index.py -q locally? (pip install wheel==0.30.0 required)
  • My extension version conforms to the Extension version schema

For new extensions:

About Extension Publish

There is a pipeline to automatically build, upload and publish extension wheels.
Once your pull request is merged into main branch, a new pull request will be created to update src/index.json automatically.
You only need to update the version information in file setup.py and historical information in file HISTORY.rst in your PR but do not modify src/index.json.

@azure-client-tools-bot-prd
Copy link

azure-client-tools-bot-prd bot commented Feb 6, 2025

️✔️Azure CLI Extensions Breaking Change Test
️✔️Non Breaking Changes

@azure-client-tools-bot-prd
Copy link

Hi @zarvd,
Please write the description of changes which can be perceived by customers into HISTORY.rst.
If you want to release a new extension version, please update the version in setup.py as well.

@azure-client-tools-bot-prd
Copy link

Hi @zarvd,
Since the current milestone time is less than 7 days, this pr will be reviewed in the next milestone.

@yonzhan
Copy link
Collaborator

yonzhan commented Feb 6, 2025

Thank you for your contribution! We will review the pull request and get back to you soon.

@github-actions
Copy link

github-actions bot commented Feb 6, 2025

The git hooks are available for azure-cli and azure-cli-extensions repos. They could help you run required checks before creating the PR.

Please sync the latest code with latest dev branch (for azure-cli) or main branch (for azure-cli-extensions).
After that please run the following commands to enable git hooks:

pip install azdev --upgrade
azdev setup -c <your azure-cli repo path> -r <your azure-cli-extensions repo path>

@github-actions
Copy link

github-actions bot commented Feb 6, 2025

Copy link
Member

@FumingZhang FumingZhang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@yonzhan
Copy link
Collaborator

yonzhan commented Feb 7, 2025

Please fix conflicting files

@yanzhudd
Copy link
Contributor

yanzhudd commented Feb 7, 2025

please resolve the code conflict.

@clnv clnv force-pushed the fix/nsg-control-validator branch from b0c801a to 5011c5d Compare February 7, 2025 08:39
@yanzhudd yanzhudd merged commit d344335 into Azure:main Feb 7, 2025
22 checks passed
@azclibot
Copy link
Collaborator

azclibot commented Feb 7, 2025

[Release] Update index.json for extension [ aks-preview-13.0.0b5 ] : https://dev.azure.com/msazure/One/_build/results?buildId=114577049&view=results

@clnv clnv deleted the fix/nsg-control-validator branch February 7, 2025 11:00
Jenniferyingni pushed a commit to Jenniferyingni/azure-cli-extensions that referenced this pull request Feb 9, 2025
…ing `--asg-ids` alone without `--allowed-host-ports` (Azure#8456)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

AKS Auto-Assign Auto assign by bot

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants