Skip to content

[Containerapp] az containerapp create: Support --kind {functionapp}#8472

Merged
zhoxing-ms merged 10 commits intoAzure:mainfrom
pragatikushwaha:pkushwaha_add_kind_containerapp_cmd
Feb 21, 2025
Merged

[Containerapp] az containerapp create: Support --kind {functionapp}#8472
zhoxing-ms merged 10 commits intoAzure:mainfrom
pragatikushwaha:pkushwaha_add_kind_containerapp_cmd

Conversation

@pragatikushwaha
Copy link
Contributor

@pragatikushwaha pragatikushwaha commented Feb 13, 2025


This checklist is used to make sure that common guidelines for a pull request are followed.

Related command

General Guidelines

  • Have you run azdev style <YOUR_EXT> locally? (pip install azdev required)
  • Have you run python scripts/ci/test_index.py -q locally? (pip install wheel==0.30.0 required)
  • My extension version conforms to the Extension version schema

For new extensions:

About Extension Publish

There is a pipeline to automatically build, upload and publish extension wheels.
Once your pull request is merged into main branch, a new pull request will be created to update src/index.json automatically.
You only need to update the version information in file setup.py and historical information in file HISTORY.rst in your PR but do not modify src/index.json.

@azure-client-tools-bot-prd
Copy link

azure-client-tools-bot-prd bot commented Feb 13, 2025

⚠️Azure CLI Extensions Breaking Change Test
⚠️containerapp
rule cmd_name rule_message suggest_message
⚠️ 1006 - ParaAdd containerapp create cmd containerapp create added parameter kind

@azure-client-tools-bot-prd
Copy link

Hi @pragatikushwaha,
Please write the description of changes which can be perceived by customers into HISTORY.rst.
If you want to release a new extension version, please update the version in setup.py as well.

@yonzhan
Copy link
Collaborator

yonzhan commented Feb 13, 2025

Thank you for your contribution! We will review the pull request and get back to you soon.

@github-actions
Copy link
Contributor

The git hooks are available for azure-cli and azure-cli-extensions repos. They could help you run required checks before creating the PR.

Please sync the latest code with latest dev branch (for azure-cli) or main branch (for azure-cli-extensions).
After that please run the following commands to enable git hooks:

pip install azdev --upgrade
azdev setup -c <your azure-cli repo path> -r <your azure-cli-extensions repo path>

@github-actions
Copy link
Contributor

CodeGen Tools Feedback Collection

Thank you for using our CodeGen tool. We value your feedback, and we would like to know how we can improve our product. Please take a few minutes to fill our codegen survey

@github-actions
Copy link
Contributor

github-actions bot commented Feb 13, 2025

Hi @pragatikushwaha

Release Suggestions

Module: containerapp

  • Update VERSION to 1.1.0b4 in src/containerapp/setup.py

Notes

@pragatikushwaha
Copy link
Contributor Author

@microsoft-github-policy-service agree company="Microsoft"

@Greedygre
Copy link
Contributor

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 2 pipeline(s).

@Greedygre
Copy link
Contributor

Greedygre commented Feb 19, 2025

The style check can be fixed after PR merged: #8483

This PR has been merged, please sync the main branch.

@Greedygre
Copy link
Contributor

please sync the main branch and resolve the conflict

Copy link
Contributor

@Greedygre Greedygre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, please resolve the small conflict

@Greedygre
Copy link
Contributor

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 2 pipeline(s).

@pragatikushwaha pragatikushwaha changed the title [Containerapp] az containerapp create/update: Support --kind {functionapp} [Containerapp] az containerapp create: Support --kind {functionapp} Feb 20, 2025
@Greedygre
Copy link
Contributor

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 2 pipeline(s).

@zhoxing-ms zhoxing-ms merged commit 1660890 into Azure:main Feb 21, 2025
22 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

8 participants