{serviceconnector-passwordless}: Support Fabric As Target Service#8482
Merged
kairu-ms merged 14 commits intoAzure:mainfrom Feb 21, 2025
Merged
Conversation
|
| rule | cmd_name | rule_message | suggest_message |
|---|---|---|---|
| aks connection create mysql-flexible | cmd aks connection create mysql-flexible added parameter connstr_props |
||
| aks connection create postgres-flexible | cmd aks connection create postgres-flexible added parameter connstr_props |
||
| aks connection create sql | cmd aks connection create sql added parameter connstr_props |
||
| containerapp connection create fabric-sql | cmd containerapp connection create fabric-sql added |
||
| containerapp connection create mysql-flexible | cmd containerapp connection create mysql-flexible added parameter connstr_props |
||
| containerapp connection create postgres-flexible | cmd containerapp connection create postgres-flexible added parameter connstr_props |
||
| containerapp connection create sql | cmd containerapp connection create sql added parameter connstr_props |
||
| functionapp connection create fabric-sql | cmd functionapp connection create fabric-sql added |
||
| functionapp connection create mysql-flexible | cmd functionapp connection create mysql-flexible added parameter connstr_props |
||
| functionapp connection create postgres-flexible | cmd functionapp connection create postgres-flexible added parameter connstr_props |
||
| functionapp connection create sql | cmd functionapp connection create sql added parameter connstr_props |
||
| webapp connection create fabric-sql | cmd webapp connection create fabric-sql added |
||
| webapp connection create mysql-flexible | cmd webapp connection create mysql-flexible added parameter connstr_props |
||
| webapp connection create postgres-flexible | cmd webapp connection create postgres-flexible added parameter connstr_props |
||
| webapp connection create sql | cmd webapp connection create sql added parameter connstr_props |
|
Hi @Tonychen0227, |
Contributor
|
The git hooks are available for azure-cli and azure-cli-extensions repos. They could help you run required checks before creating the PR. Please sync the latest code with latest dev branch (for azure-cli) or main branch (for azure-cli-extensions). pip install azdev --upgrade
azdev setup -c <your azure-cli repo path> -r <your azure-cli-extensions repo path>
|
Collaborator
|
Thank you for your contribution! We will review the pull request and get back to you soon. |
microsoft-github-policy-service
bot
requested review from
jsntcy and
kairu-ms
Contributor
|
added 3 commits
February 17, 2025 16:50
github-actions
bot
added
the
release-version-block
xfz11
reviewed
Feb 18, 2025
src/serviceconnector-passwordless/azext_serviceconnector_passwordless/_credential_free.py
Outdated
Show resolved
Hide resolved
kairu-ms
added
stable
github-actions
bot
added
the
release-version-block
AllyW
reviewed
Feb 19, 2025
src/serviceconnector-passwordless/azext_serviceconnector_passwordless/_params.py
Show resolved
Hide resolved
github-actions
bot
removed
the
release-version-block
wchigit
reviewed
Feb 19, 2025
src/serviceconnector-passwordless/azext_serviceconnector_passwordless/_resource_config.py
Show resolved
Hide resolved
wchigit
reviewed
Feb 19, 2025
Contributor
wchigit
left a comment
wchigit
left a comment
There was a problem hiding this comment.
Does fabric sql support interactive input mode? If so, what is the behavior with the connstr_props?
Contributor
Author
As discussed offline, there are a future refactoring opportunities:
|
wchigit
reviewed
Feb 19, 2025
...xt_serviceconnector_passwordless/tests/latest/test_serviceconnector-passwordless_scenario.py
Show resolved
Hide resolved
wchigit
approved these changes
Feb 19, 2025
Contributor
Author
|
@kairu-ms - Approval has been granted, could you please run CI, and approve if passed? Thanks! |
Contributor
Author
|
/azp run |
|
Commenter does not have sufficient privileges for PR 8482 in repo Azure/azure-cli-extensions |
Collaborator
|
/azp run |
|
Azure Pipelines successfully started running 2 pipeline(s). |
Contributor
Author
|
@kairu-ms - could you please help to merge this PR now that merge validation has passed? |
Contributor
|
/azp run |
|
Azure Pipelines successfully started running 2 pipeline(s). |
kairu-ms
approved these changes
Feb 21, 2025
Collaborator
|
[Release] Update index.json for extension [ serviceconnector-passwordless-3.2.0 ] : https://dev.azure.com/msazure/One/_build/results?buildId=115822315&view=results |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This checklist is used to make sure that common guidelines for a pull request are followed.
Related command
General Guidelines
azdev style <YOUR_EXT>locally? (pip install azdevrequired)python scripts/ci/test_index.py -qlocally? (pip install wheel==0.30.0required)For new extensions:
About Extension Publish
There is a pipeline to automatically build, upload and publish extension wheels.
Once your pull request is merged into main branch, a new pull request will be created to update
src/index.jsonautomatically.You only need to update the version information in file setup.py and historical information in file HISTORY.rst in your PR but do not modify
src/index.json.