Skip to content

{NexusIdentity}: Add support for nexus identity for Linux OS. #8485

Merged
kairu-ms merged 6 commits intoAzure:mainfrom
rpuri-msft:rpuri-msft/aznexid-ext
Feb 28, 2025
Merged

{NexusIdentity}: Add support for nexus identity for Linux OS. #8485
kairu-ms merged 6 commits intoAzure:mainfrom
rpuri-msft:rpuri-msft/aznexid-ext

Conversation

@rpuri-msft
Copy link
Contributor

@rpuri-msft rpuri-msft commented Feb 18, 2025


This checklist is used to make sure that common guidelines for a pull request are followed.

Related command

General Guidelines

  • Have you run azdev style <YOUR_EXT> locally? (pip install azdev required)
  • Have you run python scripts/ci/test_index.py -q locally? (pip install wheel==0.30.0 required)
  • My extension version conforms to the Extension version schema

For new extensions:

About Extension Publish

There is a pipeline to automatically build, upload and publish extension wheels.
Once your pull request is merged into main branch, a new pull request will be created to update src/index.json automatically.
You only need to update the version information in file setup.py and historical information in file HISTORY.rst in your PR but do not modify src/index.json.

@azure-client-tools-bot-prd
Copy link

azure-client-tools-bot-prd bot commented Feb 18, 2025

️✔️Azure CLI Extensions Breaking Change Test
️✔️Non Breaking Changes

@azure-client-tools-bot-prd
Copy link

Hi @rpuri-msft,
Please write the description of changes which can be perceived by customers into HISTORY.rst.
If you want to release a new extension version, please update the version in setup.py as well.

@github-actions
Copy link
Contributor

The git hooks are available for azure-cli and azure-cli-extensions repos. They could help you run required checks before creating the PR.

Please sync the latest code with latest dev branch (for azure-cli) or main branch (for azure-cli-extensions).
After that please run the following commands to enable git hooks:

pip install azdev --upgrade
azdev setup -c <your azure-cli repo path> -r <your azure-cli-extensions repo path>

@yonzhan
Copy link
Collaborator

yonzhan commented Feb 18, 2025

Thank you for your contribution! We will review the pull request and get back to you soon.

@github-actions
Copy link
Contributor

github-actions bot commented Feb 18, 2025

@necusjz
Copy link
Member

necusjz commented Feb 19, 2025

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 2 pipeline(s).

@kairu-ms
Copy link
Contributor

Please fix the failed tests. You can leverage on the git hooks:

The git hooks are available for azure-cli and azure-cli-extensions repos. They could help you run required checks before creating the PR. Please sync the latest code with latest dev branch (for azure-cli) or main branch (for azure-cli-extensions). After that please run the following commands to enable git hooks:

pip install azdev --upgrade
azdev setup -c <your azure-cli repo path> -r <your azure-cli-extensions repo path>

@wangzelin007
Copy link
Member

Please fix the failed tests. You can leverage on the git hooks:

The git hooks are available for azure-cli and azure-cli-extensions repos. They could help you run required checks before creating the PR. Please sync the latest code with latest dev branch (for azure-cli) or main branch (for azure-cli-extensions). After that please run the following commands to enable git hooks:

pip install azdev --upgrade
azdev setup -c <your azure-cli repo path> -r <your azure-cli-extensions repo path>

@kairu-ms
The test error is because they now support the Linux platform, but the version of OpenSSH on the test machine is lower than 9.4. Should we upgrade the OpenSSH version to 9.4, or should we directly mark it as recording only?

@kairu-ms
Copy link
Contributor

Please fix the failed tests. You can leverage on the git hooks:
The git hooks are available for azure-cli and azure-cli-extensions repos. They could help you run required checks before creating the PR. Please sync the latest code with latest dev branch (for azure-cli) or main branch (for azure-cli-extensions). After that please run the following commands to enable git hooks:

pip install azdev --upgrade
azdev setup -c <your azure-cli repo path> -r <your azure-cli-extensions repo path>

@kairu-ms The test error is because they now support the Linux platform, but the version of OpenSSH on the test machine is lower than 9.4. Should we upgrade the OpenSSH version to 9.4, or should we directly mark it as recording only?

@rpuri-msf, did you add the verification of OpenSSH versions which are not supported in the code?

@rpuri-msft rpuri-msft closed this Feb 26, 2025
@rpuri-msft rpuri-msft reopened this Feb 26, 2025
@necusjz
Copy link
Member

necusjz commented Feb 27, 2025

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 2 pipeline(s).

@kairu-ms kairu-ms merged commit 8cd4c97 into Azure:main Feb 28, 2025
21 of 22 checks passed
@azclibot
Copy link
Collaborator

[Release] Update index.json for extension [ nexusidentity-1.0.0b4 ] : https://dev.azure.com/msazure/One/_build/results?buildId=116507343&view=results

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants