Skip to content

Conversation

@AgarwalVivek
Copy link
Contributor

@AgarwalVivek AgarwalVivek commented Mar 6, 2025


Description

This PR is to remove the client side validation for restores which is causing timeouts for large restores. There are checks in place in the server side which does all the validation. The check in here is to fail early. Given it is causing timeouts essentially making the cli unusable we are removing this check.

Related command

az cosmosdb restore

General Guidelines

  • Have you run azdev style <YOUR_EXT> locally? (pip install azdev required)
  • Have you run python scripts/ci/test_index.py -q locally? (pip install wheel==0.30.0 required)
  • My extension version conforms to the Extension version schema

For new extensions:

About Extension Publish

There is a pipeline to automatically build, upload and publish extension wheels.
Once your pull request is merged into main branch, a new pull request will be created to update src/index.json automatically.
You only need to update the version information in file setup.py and historical information in file HISTORY.rst in your PR but do not modify src/index.json.

@azure-client-tools-bot-prd
Copy link

azure-client-tools-bot-prd bot commented Mar 6, 2025

️✔️Azure CLI Extensions Breaking Change Test
️✔️Non Breaking Changes

@azure-client-tools-bot-prd
Copy link

Hi @AgarwalVivek,
Please write the description of changes which can be perceived by customers into HISTORY.rst.
If you want to release a new extension version, please update the version in setup.py as well.

@yonzhan
Copy link
Collaborator

yonzhan commented Mar 6, 2025

Thank you for your contribution! We will review the pull request and get back to you soon.

@github-actions
Copy link

github-actions bot commented Mar 6, 2025

The git hooks are available for azure-cli and azure-cli-extensions repos. They could help you run required checks before creating the PR.

Please sync the latest code with latest dev branch (for azure-cli) or main branch (for azure-cli-extensions).
After that please run the following commands to enable git hooks:

pip install azdev --upgrade
azdev setup -c <your azure-cli repo path> -r <your azure-cli-extensions repo path>

@AgarwalVivek AgarwalVivek changed the title Skip Client Side Restore Validation Causing Timeouts Skip Client Side Restore Validation Causing Timeouts for Large Restores Mar 6, 2025
@microsoft-github-policy-service microsoft-github-policy-service bot added the customer-reported Issues that are reported by GitHub users external to the Azure organization. label Mar 6, 2025
@github-actions
Copy link

github-actions bot commented Mar 6, 2025

@vinhms
Copy link
Contributor

vinhms commented Mar 6, 2025

LGTM

@yonzhan yonzhan requested review from calvinhzy and evelyn-ys March 7, 2025 00:21
@github-actions github-actions bot added the release-version-block Updates do not qualify release version rules. NOTE: please do not edit it manually. label Mar 7, 2025
@evelyn-ys
Copy link
Member

@AgarwalVivek Pls resolve conflicts first

@github-actions github-actions bot removed the release-version-block Updates do not qualify release version rules. NOTE: please do not edit it manually. label Mar 7, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

customer-reported Issues that are reported by GitHub users external to the Azure organization.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants