Skip to content

Conversation

@Sandido
Copy link
Contributor

@Sandido Sandido commented Mar 7, 2025


This parameter has been misleading for a while, will just become a flag parameter now instead of incorrectly using the False boolean as a true value and creating a public ip anyway.

This checklist is used to make sure that common guidelines for a pull request are followed.

Related command

az vm repair create

General Guidelines

  • Have you run azdev style <YOUR_EXT> locally? (pip install azdev required)
  • Have you run python scripts/ci/test_index.py -q locally? (pip install wheel==0.30.0 required)
  • My extension version conforms to the Extension version schema

For new extensions:

About Extension Publish

There is a pipeline to automatically build, upload and publish extension wheels.
Once your pull request is merged into main branch, a new pull request will be created to update src/index.json automatically.
You only need to update the version information in file setup.py and historical information in file HISTORY.rst in your PR but do not modify src/index.json.

@azure-client-tools-bot-prd
Copy link

azure-client-tools-bot-prd bot commented Mar 7, 2025

️✔️Azure CLI Extensions Breaking Change Test
️✔️Non Breaking Changes

@azure-client-tools-bot-prd
Copy link

Hi @Sandido,
Please write the description of changes which can be perceived by customers into HISTORY.rst.
If you want to release a new extension version, please update the version in setup.py as well.

@github-actions
Copy link

github-actions bot commented Mar 7, 2025

The git hooks are available for azure-cli and azure-cli-extensions repos. They could help you run required checks before creating the PR.

Please sync the latest code with latest dev branch (for azure-cli) or main branch (for azure-cli-extensions).
After that please run the following commands to enable git hooks:

pip install azdev --upgrade
azdev setup -c <your azure-cli repo path> -r <your azure-cli-extensions repo path>

@github-actions
Copy link

github-actions bot commented Mar 7, 2025

@github-actions github-actions bot added release-version-block Updates do not qualify release version rules. NOTE: please do not edit it manually. and removed release-version-block Updates do not qualify release version rules. NOTE: please do not edit it manually. labels Mar 7, 2025
@yonzhan
Copy link
Collaborator

yonzhan commented Mar 7, 2025

Compute

zhoxing-ms
zhoxing-ms previously approved these changes Mar 10, 2025
@zhoxing-ms
Copy link
Contributor

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 2 pipeline(s).

@ReaNAiveD
Copy link
Member

Hi @Sandido , we are exploring a new way to announce breaking changes. And in this breaking change window we plan to extend the scope from core cli to extensions. If we use the new announcement method, we will have a scheduled pipeline to collect these breaking changes in a centralized document(https://learn.microsoft.com/en-us/cli/azure/upcoming-breaking-changes).
Could you take some time to try the new way to announce breaking changes?
https://github.com/Azure/azure-cli/blob/dev/doc/how_to_introduce_breaking_changes.md

Since the pipeline part is not ready yet (though it will be ready this month), you could try our new method (and I will use it as an example to ensure it displays correctly in the document), or you can just ping Xing and let him review and merge the original PR.
Please note that we are exploring ways to manage breaking changes better, so in the near future, the new way to announce breaking changes will be required.
cc @zhoxing-ms

@Alex-AZPS
Copy link

@Sandido Does Azure PowerShell also have this breaking change?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Auto-Assign Auto assign by bot Compute

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants