-
Notifications
You must be signed in to change notification settings - Fork 1.5k
Breaking change message for associate-public-ip #8535
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
️✔️Azure CLI Extensions Breaking Change Test
|
|
Hi @Sandido, |
|
The git hooks are available for azure-cli and azure-cli-extensions repos. They could help you run required checks before creating the PR. Please sync the latest code with latest dev branch (for azure-cli) or main branch (for azure-cli-extensions). pip install azdev --upgrade
azdev setup -c <your azure-cli repo path> -r <your azure-cli-extensions repo path>
|
|
|
Compute |
|
/azp run |
|
Azure Pipelines successfully started running 2 pipeline(s). |
…cli-extensions into adsandor/breakmsg
|
Hi @Sandido , we are exploring a new way to announce breaking changes. And in this breaking change window we plan to extend the scope from core cli to extensions. If we use the new announcement method, we will have a scheduled pipeline to collect these breaking changes in a centralized document(https://learn.microsoft.com/en-us/cli/azure/upcoming-breaking-changes). Since the pipeline part is not ready yet (though it will be ready this month), you could try our new method (and I will use it as an example to ensure it displays correctly in the document), or you can just ping Xing and let him review and merge the original PR. |
|
@Sandido Does Azure PowerShell also have this breaking change? |
This parameter has been misleading for a while, will just become a flag parameter now instead of incorrectly using the False boolean as a true value and creating a public ip anyway.
This checklist is used to make sure that common guidelines for a pull request are followed.
Related command
az vm repair create
General Guidelines
azdev style <YOUR_EXT>locally? (pip install azdevrequired)python scripts/ci/test_index.py -qlocally? (pip install wheel==0.30.0required)For new extensions:
About Extension Publish
There is a pipeline to automatically build, upload and publish extension wheels.
Once your pull request is merged into main branch, a new pull request will be created to update
src/index.jsonautomatically.You only need to update the version information in file setup.py and historical information in file HISTORY.rst in your PR but do not modify
src/index.json.