fix(cssc): 31250186 remove the explicit 'required=False' under _params.py #8686
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
cegraybl
commented
Apr 24, 2025
cegraybl
commented
- for update command, for parameter --config
- for list command, for parameter --run-status
# Fix LINT and Style issues # Add more unit test # Add defer_run_immediately support in the CLI command # Change the command from supply-chain task to supply-chain workflow - Need to read document # Change the show command to display cadence as "n"d instead of cron expression, order the list by name # Check if Resource_group is coming as mandatory field Or it can be set in the config and can be fetched directly from there
remove redundant files
Fix formatting Fix bugs
breaking test cases
…azure-cli-extensions into users/puwalech/acrcssc
…azure-cli-extensions into users/puwalech/acrcssc
help file default values in documentation test invalid json values
…azure-cli-extensions into users/puwalech/acrcssc
…ests (#31) Currently, no validation error is thrown when repositories are empty or repeated in configuration file. Bug - https://msazure.visualstudio.com/AzureContainerRegistry/_workitems/edit/31695069/?view=edit This PR fixes the issue by enhancing schema validation for repositories and updating the tests to test for this scenario.  --------- Co-authored-by: Ruchi Maheshwari <[email protected]>
…e calling list command + enhance log message (#32) This PR adds a check to ensure that the cssc tasks exist before calling the list command. It also displays that the list command is executed for the last n days. Updated tests as well. With this, below 2 bugs are addressed: 1. https://msazure.visualstudio.com/AzureContainerRegistry/_workitems/edit/31694510/?view=edit Before Fix:  After Fix:  2. https://msazure.visualstudio.com/AzureContainerRegistry/_workitems/edit/31694600/?view=edit After Fix: added a line to indicate list executed for last n days:  --------- Co-authored-by: Ruchi Maheshwari <[email protected]>
…iately options are mutually exclusive (#33) Added validation to ensure that the `--dryrun` and `--run-immediately` options cannot be used together both during create and update. Also added unit tests for this scenario to ensure the validation works as expected. Bug - https://msazure.visualstudio.com/AzureContainerRegistry/_workitems/edit/31694592/?view=edit After fix:  Co-authored-by: Ruchi Maheshwari <[email protected]>
…mage fix bug (#35) Updated the cssc image to latest to conclude on the duplicate image fix bug - https://msazure.visualstudio.com/AzureContainerRegistry/_workitems/edit/31695069/?view=edit --------- Co-authored-by: Ruchi Maheshwari <[email protected]> Co-authored-by: Cesar Gray Blanco <[email protected]>
To retrieve task logs class `WorkflowTaskStatus` uses a Poller to wait for a task run to finish before attempting to download the logs. This is only done during image limit check or when the `--dry-run` option is used during the `create` and `update` commands. Since this is a remote call there is a chance that we never get a response. This PR adds a 10-minute timeout to the Poller. In case the timeout is reached, the required message is logged, and the attempt will be done to retrieve the logs if there are any to allow the operation to continue. In case of a timeout during `create` or `update` the command will not block in case the image limit check could not be performed, to allow for a better user experience. In case the image limit is reached, the user will be informed via the trigger task that will perform the check every time it runs.
…l any running scan or patch task (#34) This change allows the 'delete' command to check and prompt to cancel any running scan or patch task before deleting the workflow. the operation will not prompt id used with the parameter `--yes|-y` and accepts `--dryrun` which will run the command without executing the cancellation of the tasks. Includes small fixes for style and lint issues. 
…ner Registry Tasks Contributor' (#38) Change role assignment during deployment from 'Contributor' to 'Container Registry Tasks Contributor' to trigger and scan tasks during deployment. Reduce access given to the CSSC tasks. For the new role assignment to take effect the tasks have to be redeployed.
#39) This change is only to add check for empty token. A following PR will be made to update the oras package. Since there are substantial changes to the client usage. Adding a centralized check for every token we retrieve from the registry and improve on error logging
Fix filtering on the `list` command by `--run-status` to make it correct once again. Now the `--run-status` will filter the image status depending on the final status of both the scan and patch instead of only one of them. Meaning that for an image to be marked as `FAILED` scan or patch have to be `FAILED`, for an image to be marked as `SUCCEEDED` both scan and patch have to be `SUCCEEDED` or `SKIPPED` as that is treated as a successful execution, and for an image to be marked as `SKIPPED` the scan has to be `SUCCEEDED` and the patch has to be `SKIPPED`. This PR also includes a unit test to catch issues with the filtering. In addition, includes fixes for unit tests that are run without azure credentials, adding the required mocks to avoid that dependency.
…41) This change is a continuation of the changes in [PR 39](#39) Updates the `oras` packages to 0.2.25 to use a more recent version of the package to avoid the "empty token" error when authenticating to the registry. --------- Co-authored-by: Copilot <[email protected]>
This change addresses all the comments in the [public repo PR](Azure#8530). Final change for public preview. Test passes, lint and style are successful.
…it) (#44) This change addresses all the comments in the official repo Final change for public preview. Test passes, lint and style are successful.
…45) critical items found during bug bash To fail faster and avoid creating a task without configuration the extension has to push the configuration before attempting to deploy
…15 (#46) Address a partial list of PR comments on the public PR: Azure#8530 Rest of comments require additional consideration.
…16 (#47) Second wave of PR comments for Azure#8530 Fix remaining open comments on public PR until 04/16/25 Test, style and linter are clean
…422 (#48) Third wave of PR comments for Azure#8530 Fix remaining open comments on public PR until 04/22/25 Test, style and linter are clean
- remove unused recording - remove phony secrets from test live recording to avoid flagging
- fix test_acr_cssc_dry_run test, mock required dependency - add header to test file - run azdev mask' with LOW to mask anything missing
…r update and --run-status under list parameters
|
Validation for Breaking Change Starting...
Thanks for your contribution! |
cegraybl
changed the title
|
Hi @cegraybl, |
Collaborator
|
Thank you for your contribution! We will review the pull request and get back to you soon. |
Contributor
Author
|
nope, wrong target branch, sorry about the noise |
|
The git hooks are available for azure-cli and azure-cli-extensions repos. They could help you run required checks before creating the PR. Please sync the latest code with latest dev branch (for azure-cli) or main branch (for azure-cli-extensions). pip install azdev --upgrade
azdev setup -c <your azure-cli repo path> -r <your azure-cli-extensions repo path>
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.