-
Notifications
You must be signed in to change notification settings - Fork 1.5k
[AKS] Remove --enable-pod-security-policy and --disable-pod-security-policy as it's deprecated
#8720
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
❌Azure CLI Extensions Breaking Change Test
|
|
Hi @bingosummer, |
|
Thank you for your contribution! We will review the pull request and get back to you soon. |
|
The git hooks are available for azure-cli and azure-cli-extensions repos. They could help you run required checks before creating the PR. Please sync the latest code with latest dev branch (for azure-cli) or main branch (for azure-cli-extensions). pip install azdev --upgrade
azdev setup -c <your azure-cli repo path> -r <your azure-cli-extensions repo path>
|
|
|
/azp run |
|
Azure Pipelines successfully started running 2 pipeline(s). |
6077dc8 to
a21681f
Compare
|
/azp run |
|
Azure Pipelines successfully started running 2 pipeline(s). |
| type: bool | ||
| short-summary: Enable pod security policy. | ||
| long-summary: --enable-pod-security-policy is deprecated. See https://aka.ms/aks/psp for details. | ||
| - name: --disable-pod-security-policy |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I didn't remove --disable-pod-security-policy because the user should be able to disable the feature. But after re-thinking, --disable-pod-security-policy is also to set the psp property to False. So --disable-pod-security-policy is also useless. It should be also removed.
@FumingZhang right?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
removed --disable-pod-security-policy
a21681f to
8dc0193
Compare
|
Azure Pipelines successfully started running 2 pipeline(s). |
8dc0193 to
9c05b6a
Compare
|
/azp run |
|
Azure Pipelines successfully started running 2 pipeline(s). |
9c05b6a to
f3374a4
Compare
f3374a4 to
2038c7a
Compare
|
/azp run |
|
Azure Pipelines successfully started running 2 pipeline(s). |
2038c7a to
7c640cf
Compare
|
resolved conflicts |
|
/azp run |
|
Azure Pipelines successfully started running 2 pipeline(s). |
…ty-policy` as it's deprecated
7c640cf to
f36ab42
Compare
--enable-pod-security-policy and --disable-pod-security-policy as it's deprecated
|
/azp run |
|
Azure Pipelines successfully started running 2 pipeline(s). |
|
[Release] Update index.json for extension [ aks-preview-18.0.0b1 ] : https://dev.azure.com/msazure/One/_build/results?buildId=124612767&view=results |
…ty-policy` as it's deprecated (Azure#8720)
This checklist is used to make sure that common guidelines for a pull request are followed.
Related command
az aks create/update --enable-pod-security-policy/--disable-pod-security-policyhttps://learn.microsoft.com/en-us/azure/aks/use-pod-security-policies
General Guidelines
azdev style <YOUR_EXT>locally? (pip install azdevrequired)python scripts/ci/test_index.py -qlocally? (pip install wheel==0.30.0required)For new extensions:
About Extension Publish
There is a pipeline to automatically build, upload and publish extension wheels.
Once your pull request is merged into main branch, a new pull request will be created to update
src/index.jsonautomatically.You only need to update the version information in file setup.py and historical information in file HISTORY.rst in your PR but do not modify
src/index.json.