Skip to content

Conversation

@shivansh257
Copy link
Contributor

@shivansh257 shivansh257 commented May 14, 2025


This checklist is used to make sure that common guidelines for a pull request are followed.

Related command

General Guidelines

  • Have you run azdev style <YOUR_EXT> locally? (pip install azdev required)
  • Have you run python scripts/ci/test_index.py -q locally? (pip install wheel==0.30.0 required)
  • My extension version conforms to the Extension version schema

For new extensions:

About Extension Publish

There is a pipeline to automatically build, upload and publish extension wheels.
Once your pull request is merged into main branch, a new pull request will be created to update src/index.json automatically.
You only need to update the version information in file setup.py and historical information in file HISTORY.rst in your PR but do not modify src/index.json.

aaz changes : Azure/aaz#761

@shivansh257 shivansh257 requested a review from jsntcy as a code owner May 14, 2025 07:55
@azure-client-tools-bot-prd
Copy link

azure-client-tools-bot-prd bot commented May 14, 2025

❌Azure CLI Extensions Breaking Change Test
❌dynatrace
rule cmd_name rule_message suggest_message
1008 - ParaPropAdd dynatrace monitor create cmd dynatrace monitor create update parameter plan_data: added property required=True please remove property required=True for parameter plan_data of cmd dynatrace monitor create
1008 - ParaPropAdd dynatrace monitor create cmd dynatrace monitor create update parameter user_info: added property required=True please remove property required=True for parameter user_info of cmd dynatrace monitor create

@azure-client-tools-bot-prd
Copy link

Hi @shivansh257,
Since the current milestone time is less than 7 days, this pr will be reviewed in the next milestone.

@yonzhan
Copy link
Collaborator

yonzhan commented May 14, 2025

Thank you for your contribution! We will review the pull request and get back to you soon.

@github-actions
Copy link

The git hooks are available for azure-cli and azure-cli-extensions repos. They could help you run required checks before creating the PR.

Please sync the latest code with latest dev branch (for azure-cli) or main branch (for azure-cli-extensions).
After that please run the following commands to enable git hooks:

pip install azdev --upgrade
azdev setup -c <your azure-cli repo path> -r <your azure-cli-extensions repo path>

@github-actions
Copy link

CodeGen Tools Feedback Collection

Thank you for using our CodeGen tool. We value your feedback, and we would like to know how we can improve our product. Please take a few minutes to fill our codegen survey

@github-actions
Copy link

github-actions bot commented May 14, 2025

@yonzhan yonzhan requested a review from kairu-ms May 14, 2025 07:59
@github-actions github-actions bot added the release-version-block Updates do not qualify release version rules. NOTE: please do not edit it manually. label May 16, 2025
@shivansh257
Copy link
Contributor Author

@kairu-ms In this PR I have marked few fields as required. They were required fields since beginning but were not marked as required. Fixed that. No new functionality has been added.

@shivansh257 shivansh257 changed the title Update dynatrace CLI description Update dynatrace CLI description and mark fields as required May 16, 2025
@AllyW AllyW added the patch release extension module with version patch upgraded label May 19, 2025
@github-actions github-actions bot removed the release-version-block Updates do not qualify release version rules. NOTE: please do not edit it manually. label May 19, 2025
plan_data.effective_date = AAZDateTimeArg(
options=["effective-date"],
help="date when plan was applied",
required=True,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is it required?

)
class GetVmHostPayload(AAZCommand):
"""Return the payload that need to be passed in the request body for installing Dynatrace agent on a VM
"""Return payload to be included in API request body when installing Dynatrace agent on a Virtual Machine. Use this command to facilitate automated deployment of monitoring agents across VMs.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we pass a payload in the API, is this backend API? Is it used for automated deployments of agents?

@kairu-ms kairu-ms merged commit f5b41e8 into Azure:main May 21, 2025
29 of 30 checks passed
@azclibot
Copy link
Collaborator

[Release] Update index.json for extension [ dynatrace-1.1.1 ] : https://dev.azure.com/msazure/One/_build/results?buildId=124888160&view=results

bavneetsingh16 pushed a commit to AzureArcForKubernetes/k8s-extension that referenced this pull request May 23, 2025
)

* update dynatrace commands description

* update release history

* mark fields as required and update recordings

---------

Co-authored-by: Shivansh Agarwal <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

patch release extension module with version patch upgraded

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants