-
Notifications
You must be signed in to change notification settings - Fork 1.5k
Update dynatrace CLI description and mark fields as required #8745
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update dynatrace CLI description and mark fields as required #8745
Conversation
❌Azure CLI Extensions Breaking Change Test
|
|
Hi @shivansh257, |
|
Thank you for your contribution! We will review the pull request and get back to you soon. |
|
The git hooks are available for azure-cli and azure-cli-extensions repos. They could help you run required checks before creating the PR. Please sync the latest code with latest dev branch (for azure-cli) or main branch (for azure-cli-extensions). pip install azdev --upgrade
azdev setup -c <your azure-cli repo path> -r <your azure-cli-extensions repo path>
|
CodeGen Tools Feedback CollectionThank you for using our CodeGen tool. We value your feedback, and we would like to know how we can improve our product. Please take a few minutes to fill our codegen survey |
|
|
@kairu-ms In this PR I have marked few fields as required. They were required fields since beginning but were not marked as required. Fixed that. No new functionality has been added. |
| plan_data.effective_date = AAZDateTimeArg( | ||
| options=["effective-date"], | ||
| help="date when plan was applied", | ||
| required=True, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is it required?
| ) | ||
| class GetVmHostPayload(AAZCommand): | ||
| """Return the payload that need to be passed in the request body for installing Dynatrace agent on a VM | ||
| """Return payload to be included in API request body when installing Dynatrace agent on a Virtual Machine. Use this command to facilitate automated deployment of monitoring agents across VMs. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we pass a payload in the API, is this backend API? Is it used for automated deployments of agents?
|
[Release] Update index.json for extension [ dynatrace-1.1.1 ] : https://dev.azure.com/msazure/One/_build/results?buildId=124888160&view=results |
) * update dynatrace commands description * update release history * mark fields as required and update recordings --------- Co-authored-by: Shivansh Agarwal <[email protected]>
This checklist is used to make sure that common guidelines for a pull request are followed.
Related command
General Guidelines
azdev style <YOUR_EXT>locally? (pip install azdevrequired)python scripts/ci/test_index.py -qlocally? (pip install wheel==0.30.0required)For new extensions:
About Extension Publish
There is a pipeline to automatically build, upload and publish extension wheels.
Once your pull request is merged into main branch, a new pull request will be created to update
src/index.jsonautomatically.You only need to update the version information in file setup.py and historical information in file HISTORY.rst in your PR but do not modify
src/index.json.aaz changes : Azure/aaz#761