-
Notifications
You must be signed in to change notification settings - Fork 1.5k
{zones} bugfix to extension command #8758
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
️✔️Azure CLI Extensions Breaking Change Test
|
|
Hi @nielsams, |
|
The git hooks are available for azure-cli and azure-cli-extensions repos. They could help you run required checks before creating the PR. Please sync the latest code with latest dev branch (for azure-cli) or main branch (for azure-cli-extensions). pip install azdev --upgrade
azdev setup -c <your azure-cli repo path> -r <your azure-cli-extensions repo path>
|
|
Thank you for your contribution! We will review the pull request and get back to you soon. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR fixes an issue where resource type validators were not loaded before use and standardizes test fixtures by refactoring inline dictionaries.
- Introduced
load_validators()and invoked it in command loader and tests - Refactored multi-line resource dicts to concise single-line literal syntax in tests
- Updated extension loader to call
load_validators()and bumped version, plus adjusted help example
Reviewed Changes
Copilot reviewed 23 out of 23 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| src/zones/azext_zones/_resourceTypeValidation.py | Added load_validators() to dynamically import validator modules |
| src/zones/azext_zones/init.py | Invoke load_validators() in ZonesCommandsLoader |
| src/zones/azext_zones/_help.py | Corrected the first example to omit the --omit-dependent flag |
| src/zones/HISTORY.rst | Bumped extension version to 1.0.1b1 and noted bugfixes |
| src/zones/azext_zones/tests/latest/*.py | Refactored resource dict formatting and added load_validators() calls |
Comments suppressed due to low confidence (1)
src/zones/azext_zones/tests/latest/test_microsoft_compute.py:17
- The test class name 'test_microsoft_app' does not match its filename 'test_microsoft_compute.py'. Consider renaming the class to 'test_microsoft_compute' for consistency.
class test_microsoft_app(ScenarioTest):
|
|
/azp run |
|
Azure Pipelines successfully started running 2 pipeline(s). |
Co-authored-by: AllyW <[email protected]>
|
/azp run |
|
Azure Pipelines successfully started running 2 pipeline(s). |
|
[Release] Update index.json for extension [ zones-1.0.0b2 ] : https://dev.azure.com/msazure/One/_build/results?buildId=124621862&view=results |
Co-authored-by: AllyW <[email protected]>
This checklist is used to make sure that common guidelines for a pull request are followed.
Related command
az zones
Bugfixes after initial version was released. Command does not load properly in production release.
General Guidelines
azdev style <YOUR_EXT>locally? (pip install azdevrequired)python scripts/ci/test_index.py -qlocally? (pip install wheel==0.30.0required)For new extensions:
About Extension Publish
There is a pipeline to automatically build, upload and publish extension wheels.
Once your pull request is merged into main branch, a new pull request will be created to update
src/index.jsonautomatically.You only need to update the version information in file setup.py and historical information in file HISTORY.rst in your PR but do not modify
src/index.json.