Skip to content

Conversation

@nielsams
Copy link
Member

@nielsams nielsams commented May 16, 2025


This checklist is used to make sure that common guidelines for a pull request are followed.

Related command

az zones

Bugfixes after initial version was released. Command does not load properly in production release.

General Guidelines

  • [ X ] Have you run azdev style <YOUR_EXT> locally? (pip install azdev required)
  • [ X ] Have you run python scripts/ci/test_index.py -q locally? (pip install wheel==0.30.0 required)
  • [ X ] My extension version conforms to the Extension version schema

For new extensions:

About Extension Publish

There is a pipeline to automatically build, upload and publish extension wheels.
Once your pull request is merged into main branch, a new pull request will be created to update src/index.json automatically.
You only need to update the version information in file setup.py and historical information in file HISTORY.rst in your PR but do not modify src/index.json.

Copilot AI review requested due to automatic review settings May 16, 2025 12:22
@azure-client-tools-bot-prd
Copy link

azure-client-tools-bot-prd bot commented May 16, 2025

️✔️Azure CLI Extensions Breaking Change Test
️✔️Non Breaking Changes

@azure-client-tools-bot-prd
Copy link

Hi @nielsams,
Since the current milestone time is less than 7 days, this pr will be reviewed in the next milestone.

@github-actions
Copy link

The git hooks are available for azure-cli and azure-cli-extensions repos. They could help you run required checks before creating the PR.

Please sync the latest code with latest dev branch (for azure-cli) or main branch (for azure-cli-extensions).
After that please run the following commands to enable git hooks:

pip install azdev --upgrade
azdev setup -c <your azure-cli repo path> -r <your azure-cli-extensions repo path>

@yonzhan
Copy link
Collaborator

yonzhan commented May 16, 2025

Thank you for your contribution! We will review the pull request and get back to you soon.

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR fixes an issue where resource type validators were not loaded before use and standardizes test fixtures by refactoring inline dictionaries.

  • Introduced load_validators() and invoked it in command loader and tests
  • Refactored multi-line resource dicts to concise single-line literal syntax in tests
  • Updated extension loader to call load_validators() and bumped version, plus adjusted help example

Reviewed Changes

Copilot reviewed 23 out of 23 changed files in this pull request and generated 2 comments.

Show a summary per file
File Description
src/zones/azext_zones/_resourceTypeValidation.py Added load_validators() to dynamically import validator modules
src/zones/azext_zones/init.py Invoke load_validators() in ZonesCommandsLoader
src/zones/azext_zones/_help.py Corrected the first example to omit the --omit-dependent flag
src/zones/HISTORY.rst Bumped extension version to 1.0.1b1 and noted bugfixes
src/zones/azext_zones/tests/latest/*.py Refactored resource dict formatting and added load_validators() calls
Comments suppressed due to low confidence (1)

src/zones/azext_zones/tests/latest/test_microsoft_compute.py:17

  • The test class name 'test_microsoft_app' does not match its filename 'test_microsoft_compute.py'. Consider renaming the class to 'test_microsoft_compute' for consistency.
class test_microsoft_app(ScenarioTest):

@yonzhan yonzhan requested a review from kairu-ms May 16, 2025 12:25
@github-actions
Copy link

github-actions bot commented May 16, 2025

@github-actions github-actions bot added the release-version-block Updates do not qualify release version rules. NOTE: please do not edit it manually. label May 16, 2025
@yonzhan yonzhan requested a review from jsntcy May 16, 2025 12:25
@github-actions github-actions bot removed the release-version-block Updates do not qualify release version rules. NOTE: please do not edit it manually. label May 16, 2025
@AllyW
Copy link
Contributor

AllyW commented May 19, 2025

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 2 pipeline(s).

@AllyW
Copy link
Contributor

AllyW commented May 19, 2025

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 2 pipeline(s).

@AllyW AllyW merged commit ad821c5 into Azure:main May 19, 2025
24 checks passed
@azclibot
Copy link
Collaborator

[Release] Update index.json for extension [ zones-1.0.0b2 ] : https://dev.azure.com/msazure/One/_build/results?buildId=124621862&view=results

bavneetsingh16 pushed a commit to AzureArcForKubernetes/k8s-extension that referenced this pull request May 23, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants