-
Notifications
You must be signed in to change notification settings - Fork 1.5k
[vme] Add vme extension #8765
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[vme] Add vme extension #8765
Conversation
|
Validation for Breaking Change Starting...
Thanks for your contribution! |
|
Thank you for your contribution! We will review the pull request and get back to you soon. |
|
The git hooks are available for azure-cli and azure-cli-extensions repos. They could help you run required checks before creating the PR. Please sync the latest code with latest dev branch (for azure-cli) or main branch (for azure-cli-extensions). pip install azdev --upgrade
azdev setup -c <your azure-cli repo path> -r <your azure-cli-extensions repo path>
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR adds the new 'vme' extension with commands to install, uninstall, and upgrade version managed extensions for connected Kubernetes clusters.
- Introduces core functions in utils.py to handle subprocess calls and feature flag extractions.
- Implements the custom command logic, argument parsing, and testing scenarios for vme extension commands.
- Updates documentation, help files, and templates to support the extension.
Reviewed Changes
Copilot reviewed 24 out of 24 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| src/vme/azext_vme/utils.py | Implements subprocess calls, feature flag extraction, and status checking. |
| src/vme/azext_vme/custom.py, _params.py, commands.py | Provides the extension's core commands and argument definitions. |
| Tests files in src/vme/azext_vme/tests/latest/ | Implements live scenario tests for upgrade, install, and uninstall. |
| Documentation files (README.rst, _help.py, HISTORY.rst) | Adds help, version history, and readme documentation for the extension. |
| .github/CODEOWNERS | Updates ownership configuration for extension code. |
| Other supporting files | Includes client factory, actions, and initialization code. |
Comments suppressed due to low confidence (1)
.github/CODEOWNERS:331
- The CODEOWNERS entry seems to reference an incorrect path. Based on the repository structure, consider updating the owner path to '/src/vme/azext_vme/' to accurately target the extension code.
/src/azext_vme/ @caoyihua
|
|
/azp run |
|
Azure Pipelines successfully started running 2 pipeline(s). |
|
/azp run |
|
Commenter does not have sufficient privileges for PR 8765 in repo Azure/azure-cli-extensions |
|
/azp run |
|
Azure Pipelines successfully started running 2 pipeline(s). |
|
[Release] Update index.json for extension [ vme-1.0.0b1 ] : https://dev.azure.com/msazure/One/_build/results?buildId=124979770&view=results |
* Create vme to manage version managed extensions * Update vme helper messages * Perform case-insensitive comparison of the feature flag * Update readme * Update CODEOWNERS * Update version * Fix style and linter errors
This checklist is used to make sure that common guidelines for a pull request are followed.
Related command
New extension 'vme' to install/uninstall/upgrade the version managed extensions on connected kubernetes clusters.
General Guidelines
azdev style <YOUR_EXT>locally? (pip install azdevrequired)python scripts/ci/test_index.py -qlocally? (pip install wheel==0.30.0required)For new extensions:
About Extension Publish
There is a pipeline to automatically build, upload and publish extension wheels.
Once your pull request is merged into main branch, a new pull request will be created to update
src/index.jsonautomatically.You only need to update the version information in file setup.py and historical information in file HISTORY.rst in your PR but do not modify
src/index.json.