Skip to content

Conversation

@caoyihua
Copy link
Contributor


This checklist is used to make sure that common guidelines for a pull request are followed.

Related command

New extension 'vme' to install/uninstall/upgrade the version managed extensions on connected kubernetes clusters.

General Guidelines

  • [y] Have you run azdev style <YOUR_EXT> locally? (pip install azdev required)
  • [y] Have you run python scripts/ci/test_index.py -q locally? (pip install wheel==0.30.0 required)
  • [y] My extension version conforms to the Extension version schema

For new extensions:

About Extension Publish

There is a pipeline to automatically build, upload and publish extension wheels.
Once your pull request is merged into main branch, a new pull request will be created to update src/index.json automatically.
You only need to update the version information in file setup.py and historical information in file HISTORY.rst in your PR but do not modify src/index.json.

Copilot AI review requested due to automatic review settings May 19, 2025 09:20
@azure-client-tools-bot-prd
Copy link

Validation for Breaking Change Starting...

Thanks for your contribution!

@yonzhan
Copy link
Collaborator

yonzhan commented May 19, 2025

Thank you for your contribution! We will review the pull request and get back to you soon.

@github-actions
Copy link

The git hooks are available for azure-cli and azure-cli-extensions repos. They could help you run required checks before creating the PR.

Please sync the latest code with latest dev branch (for azure-cli) or main branch (for azure-cli-extensions).
After that please run the following commands to enable git hooks:

pip install azdev --upgrade
azdev setup -c <your azure-cli repo path> -r <your azure-cli-extensions repo path>

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR adds the new 'vme' extension with commands to install, uninstall, and upgrade version managed extensions for connected Kubernetes clusters.

  • Introduces core functions in utils.py to handle subprocess calls and feature flag extractions.
  • Implements the custom command logic, argument parsing, and testing scenarios for vme extension commands.
  • Updates documentation, help files, and templates to support the extension.

Reviewed Changes

Copilot reviewed 24 out of 24 changed files in this pull request and generated 1 comment.

Show a summary per file
File Description
src/vme/azext_vme/utils.py Implements subprocess calls, feature flag extraction, and status checking.
src/vme/azext_vme/custom.py, _params.py, commands.py Provides the extension's core commands and argument definitions.
Tests files in src/vme/azext_vme/tests/latest/ Implements live scenario tests for upgrade, install, and uninstall.
Documentation files (README.rst, _help.py, HISTORY.rst) Adds help, version history, and readme documentation for the extension.
.github/CODEOWNERS Updates ownership configuration for extension code.
Other supporting files Includes client factory, actions, and initialization code.
Comments suppressed due to low confidence (1)

.github/CODEOWNERS:331

  • The CODEOWNERS entry seems to reference an incorrect path. Based on the repository structure, consider updating the owner path to '/src/vme/azext_vme/' to accurately target the extension code.
/src/azext_vme/ @caoyihua

@github-actions
Copy link

github-actions bot commented May 19, 2025

@github-actions github-actions bot added the release-version-block Updates do not qualify release version rules. NOTE: please do not edit it manually. label May 19, 2025
@github-actions github-actions bot removed the release-version-block Updates do not qualify release version rules. NOTE: please do not edit it manually. label May 19, 2025
@yonzhan yonzhan requested review from jsntcy and kairu-ms May 19, 2025 13:23
@kairu-ms kairu-ms assigned necusjz and unassigned kairu-ms May 21, 2025
@kairu-ms kairu-ms requested a review from necusjz May 21, 2025 06:07
@kairu-ms
Copy link
Contributor

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 2 pipeline(s).

@caoyihua
Copy link
Contributor Author

/azp run

@azure-pipelines
Copy link

Commenter does not have sufficient privileges for PR 8765 in repo Azure/azure-cli-extensions

@yonzhan
Copy link
Collaborator

yonzhan commented May 21, 2025

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 2 pipeline(s).

@necusjz necusjz merged commit 23f3348 into Azure:main May 22, 2025
24 checks passed
@azclibot
Copy link
Collaborator

[Release] Update index.json for extension [ vme-1.0.0b1 ] : https://dev.azure.com/msazure/One/_build/results?buildId=124979770&view=results

bavneetsingh16 pushed a commit to AzureArcForKubernetes/k8s-extension that referenced this pull request May 23, 2025
* Create vme to manage version managed extensions

* Update vme helper messages

* Perform case-insensitive comparison of the feature flag

* Update readme

* Update CODEOWNERS

* Update version

* Fix style and linter errors
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants