Skip to content

Conversation

@nielsams
Copy link
Member


This checklist is used to make sure that common guidelines for a pull request are followed.

Related command

General Guidelines

  • [ X ] Have you run azdev style <YOUR_EXT> locally? (pip install azdev required)
  • [ X ] Have you run python scripts/ci/test_index.py -q locally? (pip install wheel==0.30.0 required)
  • [ X ] My extension version conforms to the Extension version schema

For new extensions:

About Extension Publish

There is a pipeline to automatically build, upload and publish extension wheels.
Once your pull request is merged into main branch, a new pull request will be created to update src/index.json automatically.
You only need to update the version information in file setup.py and historical information in file HISTORY.rst in your PR but do not modify src/index.json.

Copilot AI review requested due to automatic review settings May 19, 2025 10:03
@azure-client-tools-bot-prd
Copy link

Hi @nielsams,
Please write the description of changes which can be perceived by customers into HISTORY.rst.
If you want to release a new extension version, please update the version in setup.py as well.

@azure-client-tools-bot-prd
Copy link

azure-client-tools-bot-prd bot commented May 19, 2025

️✔️Azure CLI Extensions Breaking Change Test
️✔️Non Breaking Changes

@yonzhan
Copy link
Collaborator

yonzhan commented May 19, 2025

Thank you for your contribution! We will review the pull request and get back to you soon.

@github-actions
Copy link

The git hooks are available for azure-cli and azure-cli-extensions repos. They could help you run required checks before creating the PR.

Please sync the latest code with latest dev branch (for azure-cli) or main branch (for azure-cli-extensions).
After that please run the following commands to enable git hooks:

pip install azdev --upgrade
azdev setup -c <your azure-cli repo path> -r <your azure-cli-extensions repo path>

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR introduces minor bugfixes and code style updates across resource type validators in the Zones extension, and bumps the extension’s beta version.

  • Add # pylint: disable=too-few-public-methods to each validator module
  • Simplify conditional return statements by removing redundant else blocks
  • Fix a missing return in the Microsoft.DocumentDB validator and add a return for the BotService warning path
  • Update HISTORY.rst to 1.0.0b3

Reviewed Changes

Copilot reviewed 39 out of 39 changed files in this pull request and generated no comments.

Show a summary per file
File Description
src/zones/azext_zones/resource_type_validators/microsoft_eventhub.py Wrap long comment and simplify return
src/zones/azext_zones/resource_type_validators/microsoft_eventgrid.py Add pylint disable
src/zones/azext_zones/resource_type_validators/microsoft_documentdb.py Correct missing return in second branch
src/zones/azext_zones/resource_type_validators/microsoft_dbforpostgresql.py Simplify if/else to early return
src/zones/azext_zones/resource_type_validators/microsoft_dbformysql.py Simplify if/else to early return
src/zones/azext_zones/resource_type_validators/microsoft_dashboard.py Simplify if/else to early return
src/zones/azext_zones/resource_type_validators/microsoft_containerservice.py Convert ternary return to if/return
src/zones/azext_zones/resource_type_validators/microsoft_containerregistry.py Simplify if/else to early return
src/zones/azext_zones/resource_type_validators/microsoft_containerinstance.py Add pylint disable
src/zones/azext_zones/resource_type_validators/microsoft_compute.py Add pylint disables and simplify if/else
src/zones/azext_zones/resource_type_validators/microsoft_chaos.py Add pylint disable
src/zones/azext_zones/resource_type_validators/microsoft_cdn.py Add pylint disable
src/zones/azext_zones/resource_type_validators/microsoft_cache.py Simplify if/else to early return
src/zones/azext_zones/resource_type_validators/microsoft_botservice.py Fix missing return on warning path
src/zones/azext_zones/resource_type_validators/microsoft_automation.py Add pylint disable
src/zones/azext_zones/resource_type_validators/microsoft_authorization.py Add pylint disable
src/zones/azext_zones/resource_type_validators/microsoft_app.py Simplify if/else to early return
src/zones/azext_zones/resource_type_validators/microsoft_apimanagement.py Simplify if/else to early return
src/zones/azext_zones/resource_type_validators/init.py Add module header and docstring
src/zones/HISTORY.rst Bump to version 1.0.0b3 and add release notes
Comments suppressed due to low confidence (2)

src/zones/azext_zones/resource_type_validators/microsoft_eventhub.py:28

  • Add a unit test to verify that the Event Hubs validator always returns ZoneRedundancyValidationResult.Always for regions with availability zone support.
return ZoneRedundancyValidationResult.Always

src/zones/azext_zones/resource_type_validators/microsoft_botservice.py:36

  • Introduce a unit test covering the new warning path that returns ZoneRedundancyValidationResult.Unknown for regional Bot Service in West Europe.
return ZoneRedundancyValidationResult.Unknown

@github-actions
Copy link

@AllyW
Copy link
Contributor

AllyW commented May 20, 2025

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 2 pipeline(s).

@AllyW AllyW changed the title {Zones} Release bugfix 3 {Zones} Release bugfix to improve command loading May 20, 2025
@AllyW AllyW merged commit ae89d8e into Azure:main May 20, 2025
26 checks passed
@azclibot
Copy link
Collaborator

[Release] Update index.json for extension [ zones-1.0.0b3 ] : https://dev.azure.com/msazure/One/_build/results?buildId=124753948&view=results

bavneetsingh16 pushed a commit to AzureArcForKubernetes/k8s-extension that referenced this pull request May 23, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants