Skip to content

Conversation

@NidhiMalpani
Copy link
Contributor

About Extension Publish

There is a pipeline to automatically build, upload and publish extension wheels.
Once your pull request is merged into main branch, a new pull request will be created to update src/index.json automatically.
You only need to update the version information in file setup.py and historical information in file HISTORY.rst in your PR but do not modify src/index.json.

Copilot AI review requested due to automatic review settings May 19, 2025 13:26
@NidhiMalpani NidhiMalpani requested a review from kairu-ms as a code owner May 19, 2025 13:26
@azure-client-tools-bot-prd
Copy link

azure-client-tools-bot-prd bot commented May 19, 2025

️✔️Azure CLI Extensions Breaking Change Test
️✔️Non Breaking Changes

@azure-client-tools-bot-prd
Copy link

Hi @NidhiMalpani,
Please write the description of changes which can be perceived by customers into HISTORY.rst.
If you want to release a new extension version, please update the version in setup.py as well.

@github-actions
Copy link

The git hooks are available for azure-cli and azure-cli-extensions repos. They could help you run required checks before creating the PR.

Please sync the latest code with latest dev branch (for azure-cli) or main branch (for azure-cli-extensions).
After that please run the following commands to enable git hooks:

pip install azdev --upgrade
azdev setup -c <your azure-cli repo path> -r <your azure-cli-extensions repo path>

@yonzhan
Copy link
Collaborator

yonzhan commented May 19, 2025

Thank you for your contribution! We will review the pull request and get back to you soon.

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR updates the CLI descriptions and related metadata for the Astronomer extension. The key changes include:

  • Updating the minimum CLI core version in the metadata.
  • Improving regex pattern escapes for argument validation across several commands.
  • Changing the identity property type from AAZObjectType to AAZIdentityObjectType and refining command descriptions.

Reviewed Changes

Copilot reviewed 8 out of 8 changed files in this pull request and generated no comments.

Show a summary per file
File Description
src/astronomer/azext_astronomer/azext_metadata.json Updated the minimum CLI core version to "2.70.0".
src/astronomer/azext_astronomer/aaz/latest/astronomer/organization/_wait.py Updated regex escaping in patterns and changed the identity type to AAZIdentityObjectType.
src/astronomer/azext_astronomer/aaz/latest/astronomer/organization/_update.py Revised CLI command descriptions, regex patterns, and updated the identity property type.
src/astronomer/azext_astronomer/aaz/latest/astronomer/organization/_show.py Improved command description and updated regex and identity type usage.
src/astronomer/azext_astronomer/aaz/latest/astronomer/organization/_list.py Refined listing descriptions and switched to AAZIdentityObjectType for identities.
src/astronomer/azext_astronomer/aaz/latest/astronomer/organization/_delete.py Updated argument validation regex and enhanced the delete command description.
src/astronomer/azext_astronomer/aaz/latest/astronomer/organization/_create.py Enhanced command descriptions, regex patterns, and updated object type for identity.
src/astronomer/azext_astronomer/aaz/latest/astronomer/organization/__cmd_group.py Modified the group command description for clarity regarding Azure and Astronomer resources.

@github-actions
Copy link

CodeGen Tools Feedback Collection

Thank you for using our CodeGen tool. We value your feedback, and we would like to know how we can improve our product. Please take a few minutes to fill our codegen survey

@yonzhan yonzhan requested a review from jsntcy May 19, 2025 13:29
@github-actions
Copy link

github-actions bot commented May 19, 2025

@NidhiMalpani
Copy link
Contributor Author

@NidhiMalpani please read the following Contributor License Agreement(CLA). If you agree with the CLA, please reply with the following information.

@microsoft-github-policy-service agree [company="{your company}"]

Options:

  • (default - no company specified) I have sole ownership of intellectual property rights to my Submissions and I am not making Submissions in the course of work for my employer.
@microsoft-github-policy-service agree
  • (when company given) I am making Submissions in the course of work for my employer (or my employer has intellectual property rights in my Submissions by contract or applicable law). I have permission from my employer to make Submissions and enter into this Agreement on behalf of my employer. By signing below, the defined term “You” includes me and my employer.
@microsoft-github-policy-service agree company="Microsoft"

Contributor License Agreement

@microsoft-github-policy-service agree company="Microsoft"

@NidhiMalpani NidhiMalpani changed the title Update CLI descriptions Astronomer: Update CLI descriptions May 21, 2025
@kairu-ms
Copy link
Contributor

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 2 pipeline(s).

@kairu-ms kairu-ms merged commit 291f1cc into Azure:main May 21, 2025
24 checks passed
@azclibot
Copy link
Collaborator

[Release] Update index.json for extension [ astronomer-1.0.1 ] : https://dev.azure.com/msazure/One/_build/results?buildId=124883202&view=results

bavneetsingh16 pushed a commit to AzureArcForKubernetes/k8s-extension that referenced this pull request May 23, 2025
* Update CLI descriptions

* Update version

* Fix version sequence

---------

Co-authored-by: Nidhi Malpani <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants