-
Notifications
You must be signed in to change notification settings - Fork 1.5k
Astronomer: Update CLI descriptions #8767
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
️✔️Azure CLI Extensions Breaking Change Test
|
|
Hi @NidhiMalpani, |
|
The git hooks are available for azure-cli and azure-cli-extensions repos. They could help you run required checks before creating the PR. Please sync the latest code with latest dev branch (for azure-cli) or main branch (for azure-cli-extensions). pip install azdev --upgrade
azdev setup -c <your azure-cli repo path> -r <your azure-cli-extensions repo path>
|
|
Thank you for your contribution! We will review the pull request and get back to you soon. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR updates the CLI descriptions and related metadata for the Astronomer extension. The key changes include:
- Updating the minimum CLI core version in the metadata.
- Improving regex pattern escapes for argument validation across several commands.
- Changing the identity property type from AAZObjectType to AAZIdentityObjectType and refining command descriptions.
Reviewed Changes
Copilot reviewed 8 out of 8 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| src/astronomer/azext_astronomer/azext_metadata.json | Updated the minimum CLI core version to "2.70.0". |
| src/astronomer/azext_astronomer/aaz/latest/astronomer/organization/_wait.py | Updated regex escaping in patterns and changed the identity type to AAZIdentityObjectType. |
| src/astronomer/azext_astronomer/aaz/latest/astronomer/organization/_update.py | Revised CLI command descriptions, regex patterns, and updated the identity property type. |
| src/astronomer/azext_astronomer/aaz/latest/astronomer/organization/_show.py | Improved command description and updated regex and identity type usage. |
| src/astronomer/azext_astronomer/aaz/latest/astronomer/organization/_list.py | Refined listing descriptions and switched to AAZIdentityObjectType for identities. |
| src/astronomer/azext_astronomer/aaz/latest/astronomer/organization/_delete.py | Updated argument validation regex and enhanced the delete command description. |
| src/astronomer/azext_astronomer/aaz/latest/astronomer/organization/_create.py | Enhanced command descriptions, regex patterns, and updated object type for identity. |
| src/astronomer/azext_astronomer/aaz/latest/astronomer/organization/__cmd_group.py | Modified the group command description for clarity regarding Azure and Astronomer resources. |
CodeGen Tools Feedback CollectionThank you for using our CodeGen tool. We value your feedback, and we would like to know how we can improve our product. Please take a few minutes to fill our codegen survey |
|
@microsoft-github-policy-service agree company="Microsoft" |
|
/azp run |
|
Azure Pipelines successfully started running 2 pipeline(s). |
|
[Release] Update index.json for extension [ astronomer-1.0.1 ] : https://dev.azure.com/msazure/One/_build/results?buildId=124883202&view=results |
* Update CLI descriptions * Update version * Fix version sequence --------- Co-authored-by: Nidhi Malpani <[email protected]>
About Extension Publish
There is a pipeline to automatically build, upload and publish extension wheels.
Once your pull request is merged into main branch, a new pull request will be created to update
src/index.jsonautomatically.You only need to update the version information in file setup.py and historical information in file HISTORY.rst in your PR but do not modify
src/index.json.