fix(acrcssc): updated to allow for az login when the account doesn't have any active subs #8770
Conversation
… subscriptions assigned
️✔️Azure CLI Extensions Breaking Change Test
|
|
Hi @Ruchii-27, |
|
Thank you for your contribution! We will review the pull request and get back to you soon. |
|
The git hooks are available for azure-cli and azure-cli-extensions repos. They could help you run required checks before creating the PR. Please sync the latest code with latest dev branch (for azure-cli) or main branch (for azure-cli-extensions). pip install azdev --upgrade
azdev setup -c <your azure-cli repo path> -r <your azure-cli-extensions repo path>
|
|
…into Ruchi/FixCsscExt/TaskLoginBugFix
… subscriptions - history log updated
There was a problem hiding this comment.
Pull Request Overview
This PR updates the az login commands to include an optional parameter so that users without active subscriptions can still login, and bumps the extension version for the release.
- Updates version in setup.py and HISTORY.rst
- Modifies az login commands in two YAML workflow templates
- Updates release notes in HISTORY.rst
Reviewed Changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| src/acrcssc/setup.py | Bumps version from 1.0.0b1 to 1.0.0b2 |
| src/acrcssc/azext_acrcssc/templates/task/cssc_trigger_workflow.yaml | Updates az login command to include an extra parameter |
| src/acrcssc/azext_acrcssc/templates/task/cssc_scan_image.yaml | Updates az login command to include an extra parameter |
| src/acrcssc/HISTORY.rst | Updates release notes with version bump and fix note |
There was a problem hiding this comment.
Pull Request Overview
This PR updates the behavior of az login to support accounts without active subscriptions by adding the --allow-no-subscriptions flag.
- Bump extension version in setup.py from 1.0.0b1 to 1.0.0b2
- Update az login commands in cssc_trigger_workflow.yaml and cssc_scan_image.yaml to include --allow-no-subscriptions
- Update HISTORY.rst with the corresponding bug fix entry
Reviewed Changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| src/acrcssc/setup.py | Updated version to reflect the new release bump |
| src/acrcssc/azext_acrcssc/templates/task/cssc_trigger_workflow.yaml | Modified az login command to include the --allow-no-subscriptions flag |
| src/acrcssc/azext_acrcssc/templates/task/cssc_scan_image.yaml | Modified az login command in the vulnerability check section |
| src/acrcssc/HISTORY.rst | Added release notes for version 1.0.0b2 with the bug fix description |
Co-authored-by: Copilot <[email protected]>
|
@jiasli Please help review and merge this PR, thanks. |
|
@kairu-ms Please help review and merge this PR, thanks. |
|
/azp run |
|
Azure Pipelines successfully started running 2 pipeline(s). |
|
[Release] Update index.json for extension [ acrcssc-1.0.0b2 ] : https://dev.azure.com/msazure/One/_build/results?buildId=125383974&view=results |
6 participants
This checklist is used to make sure that common guidelines for a pull request are followed.
Related command
Update az login with optional param --allow-no-subscriptions - https://learn.microsoft.com/en-us/cli/azure/reference-index?view=azure-cli-latest#az-login-optional-parameters to fix issue described in this discussion - Azure/acr#835
General Guidelines
azdev style <YOUR_EXT>locally? (pip install azdevrequired)python scripts/ci/test_index.py -qlocally? (pip install wheel==0.30.0required)For new extensions:
About Extension Publish
There is a pipeline to automatically build, upload and publish extension wheels.
Once your pull request is merged into main branch, a new pull request will be created to update
src/index.jsonautomatically.You only need to update the version information in file setup.py and historical information in file HISTORY.rst in your PR but do not modify
src/index.json.