Skip to content

Conversation

@FumingZhang
Copy link
Member

@FumingZhang FumingZhang commented May 21, 2025


This checklist is used to make sure that common guidelines for a pull request are followed.

Related command

image

General Guidelines

  • Have you run azdev style <YOUR_EXT> locally? (pip install azdev required)
  • Have you run python scripts/ci/test_index.py -q locally? (pip install wheel==0.30.0 required)
  • My extension version conforms to the Extension version schema

For new extensions:

About Extension Publish

There is a pipeline to automatically build, upload and publish extension wheels.
Once your pull request is merged into main branch, a new pull request will be created to update src/index.json automatically.
You only need to update the version information in file setup.py and historical information in file HISTORY.rst in your PR but do not modify src/index.json.

Copilot AI review requested due to automatic review settings May 21, 2025 00:55
@azure-client-tools-bot-prd
Copy link

azure-client-tools-bot-prd bot commented May 21, 2025

❌Azure CLI Extensions Breaking Change Test
❌aks-preview
rule cmd_name rule_message suggest_message
1010 - ParaPropUpdate aks nodepool add cmd aks nodepool add update parameter spot_max_price: updated property default from nan to nan please change property default from nan to nan for parameter spot_max_price of cmd aks nodepool add
⚠️ 1006 - ParaAdd aks nodepool add cmd aks nodepool add added parameter gpu_driver
⚠️ 1008 - ParaPropAdd aks nodepool add cmd aks nodepool add update parameter skip_gpu_driver_install: added property deprecate_info_hide=True
⚠️ 1008 - ParaPropAdd aks nodepool add cmd aks nodepool add update parameter skip_gpu_driver_install: added property deprecate_info_redirect=--gpu-driver
⚠️ 1008 - ParaPropAdd aks nodepool add cmd aks nodepool add update parameter skip_gpu_driver_install: added property deprecate_info_target=--skip-gpu-driver-install

@azure-client-tools-bot-prd
Copy link

Hi @FumingZhang,
Please write the description of changes which can be perceived by customers into HISTORY.rst.
If you want to release a new extension version, please update the version in setup.py as well.

@yonzhan
Copy link
Collaborator

yonzhan commented May 21, 2025

Thank you for your contribution! We will review the pull request and get back to you soon.

@github-actions
Copy link

The git hooks are available for azure-cli and azure-cli-extensions repos. They could help you run required checks before creating the PR.

Please sync the latest code with latest dev branch (for azure-cli) or main branch (for azure-cli-extensions).
After that please run the following commands to enable git hooks:

pip install azdev --upgrade
azdev setup -c <your azure-cli repo path> -r <your azure-cli-extensions repo path>

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR vendors the new AKS SDK and bumps the AKS API version from 2025-02-02-preview to 2025-03-02-preview across recording tests, registration code, and documentation.

  • Updated recording URIs in test YAMLs to use the new API version.
  • Adjusted SDKProfile registration in __init__.py.
  • Added mapping for the new version in README.rst and a new entry in HISTORY.rst.

Reviewed Changes

Copilot reviewed 252 out of 252 changed files in this pull request and generated no comments.

File Description
tests/latest/recordings/*.yaml (many) Updated all api-version query params to 2025-03-02-preview
azext_aks_preview/__init__.py Bumped SDKProfile API version to 2025-03-02-preview
README.rst Added new version mapping for 18.0.0b2 → latest
HISTORY.rst Added entry for 18.0.0b2 release

@github-actions
Copy link

@zhoxing-ms zhoxing-ms merged commit 9e890e1 into Azure:main May 21, 2025
24 checks passed
@azclibot
Copy link
Collaborator

[Release] Update index.json for extension [ aks-preview-18.0.0b2 ] : https://dev.azure.com/msazure/One/_build/results?buildId=124872953&view=results

bavneetsingh16 pushed a commit to AzureArcForKubernetes/k8s-extension that referenced this pull request May 23, 2025
@FumingZhang FumingZhang deleted the fuming/aks-vendor-sdk-0521 branch September 10, 2025 03:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

AKS Auto-Assign Auto assign by bot

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants