[AKS] chore: remove --skip-gpu-driver-install #8777
Conversation
❌Azure CLI Extensions Breaking Change Test
|
|
Hi @lilypan26, |
|
Thank you for your contribution! We will review the pull request and get back to you soon. |
|
The git hooks are available for azure-cli and azure-cli-extensions repos. They could help you run required checks before creating the PR. Please sync the latest code with latest dev branch (for azure-cli) or main branch (for azure-cli-extensions). pip install azdev --upgrade
azdev setup -c <your azure-cli repo path> -r <your azure-cli-extensions repo path>
|
microsoft-github-policy-service
bot
requested review from
yanzhudd,
yonzhan and
zhoxing-ms
There was a problem hiding this comment.
Pull Request Overview
This PR updates and re-enables the GPU driver install tests to use the new --gpu-driver parameter and removes the deprecated skip_gpu_driver_install logic and tests.
- Re-enable and adapt the
test_aks_skip_gpu_driver_installintest_aks_commands.pyto use--gpu-driver None/Installand assert ongpuProfile.driver. - Remove all
skip_gpu_driver_installmethods inagentpool_decorator.pyand associated tests intest_agentpool_decorator.py. - Align CLI tests with the new API flag semantics for GPU driver configuration.
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| src/aks-preview/azext_aks_preview/tests/latest/test_aks_commands.py | Re-enabled and updated GPU driver skip/install test using new flag. |
| src/aks-preview/azext_aks_preview/tests/latest/test_agentpool_decorator.py | Removed obsolete skip_gpu_driver_install test helpers and calls. |
| src/aks-preview/azext_aks_preview/agentpool_decorator.py | Deleted deprecated get_skip_gpu_driver_install and set_up_skip_gpu_driver_install. |
| "--resource-group={resource_group} " | ||
| "--cluster-name={name} " | ||
| "--name={nodepool_name_second} " | ||
| "--node-vm-size={node_vm_size} " |
There was a problem hiding this comment.
The placeholder {node_vm_size} is never set in self.kwargs. Add "node_vm_size": <desired_value> to self.kwargs.update(...) before using it, or remove the placeholder if it's not needed.
| # "aks delete -g {resource_group} -n {name} --yes --no-wait", | ||
| # checks=[self.is_empty()], | ||
| # ) | ||
| # nodepool delete the second |
There was a problem hiding this comment.
The comment is misleading: this command deletes the first node pool ({nodepool_name}), not the second. Update the comment to accurately describe the deletion target.
| # nodepool delete the second | |
| # delete the first node pool |
|
Hi @lilypan26 Release SuggestionsModule: aks-preview
Notes
|
FumingZhang
left a comment
FumingZhang
left a comment
There was a problem hiding this comment.
Queued live test to validate the change.
- test_aks_skip_gpu_driver_install
BTW, please commit new recording file for the new test case to pass CI checks.
| Pending | ||
| +++++++ | ||
|
|
||
| 18.0.0b3 |
There was a problem hiding this comment.
Please choose a new major version like 19.0.0b1 as you're making a breaking change.
https://github.com/Azure/azure-cli/blob/release/doc/extensions/versioning_guidelines.md
lilypan26
changed the title
5 participants
This checklist is used to make sure that common guidelines for a pull request are followed.
Related command
--skip-gpu-driver-install, --gpu-driver None/Install
General Guidelines
azdev style <YOUR_EXT>locally? (pip install azdevrequired)python scripts/ci/test_index.py -qlocally? (pip install wheel==0.30.0required)For new extensions:
About Extension Publish
There is a pipeline to automatically build, upload and publish extension wheels.
Once your pull request is merged into main branch, a new pull request will be created to update
src/index.jsonautomatically.You only need to update the version information in file setup.py and historical information in file HISTORY.rst in your PR but do not modify
src/index.json.