-
Notifications
You must be signed in to change notification settings - Fork 1.5k
CosmosDB Fleet Preview #8778
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
CosmosDB Fleet Preview #8778
Conversation
|
Validation for Breaking Change Starting...
Thanks for your contribution! |
|
Hi @pjohari-ms, |
|
Thank you for your contribution! We will review the pull request and get back to you soon. |
|
The git hooks are available for azure-cli and azure-cli-extensions repos. They could help you run required checks before creating the PR. Please sync the latest code with latest dev branch (for azure-cli) or main branch (for azure-cli-extensions). pip install azdev --upgrade
azdev setup -c <your azure-cli repo path> -r <your azure-cli-extensions repo path>
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
Adds support for specifying global database account properties on Fleetspace accounts within the CosmosDB preview SDK.
- Introduces a new
FleetspaceAccountPropertiesGlobalDatabaseAccountPropertiesmodel. - Replaces the old
account_resource_identifierandaccount_locationfields onFleetspaceAccountResourcewith the newglobal_database_account_propertiesfield. - Exports the new model in the package’s
__init__.py.
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| src/cosmosdb-preview/azext_cosmosdb_preview/vendored_sdks/azure_mgmt_cosmosdb/models/_models_py3.py | Added FleetspaceAccountPropertiesGlobalDatabaseAccountProperties class and updated FleetspaceAccountResource. |
| src/cosmosdb-preview/azext_cosmosdb_preview/vendored_sdks/azure_mgmt_cosmosdb/models/init.py | Added the new model to the module import list and __all__. |
Comments suppressed due to low confidence (1)
src/cosmosdb-preview/azext_cosmosdb_preview/vendored_sdks/azure_mgmt_cosmosdb/models/_models_py3.py:7955
- Consider adding unit tests for the new
FleetspaceAccountPropertiesGlobalDatabaseAccountPropertiesmodel to verify serialization behavior and attribute mapping.
class FleetspaceAccountPropertiesGlobalDatabaseAccountProperties(_serialization.Model): # pylint: disable=name-too-long
| """Configuration for fleetspace Account in the fleetspace. | ||
|
|
||
| :ivar resource_id: The resource identifier of global database account in the Fleetspace | ||
| Account. | ||
| :vartype resource_id: str | ||
| :ivar arm_location: The location of global database account in the Fleetspace Account. |
Copilot
AI
May 21, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[nitpick] The class docstring is phrased as 'Configuration for fleetspace Account in the fleetspace.' Consider rewording for clarity and consistent capitalization, e.g., 'Configuration for a global database account in the Fleetspace account.'
| """Configuration for fleetspace Account in the fleetspace. | |
| :ivar resource_id: The resource identifier of global database account in the Fleetspace | |
| Account. | |
| :vartype resource_id: str | |
| :ivar arm_location: The location of global database account in the Fleetspace Account. | |
| """Configuration for a global database account in the Fleetspace account. | |
| :ivar resource_id: The resource identifier of the global database account in the Fleetspace | |
| account. | |
| :vartype resource_id: str | |
| :ivar arm_location: The location of the global database account in the Fleetspace account. |
| :ivar resource_id: The resource identifier of global database account in the Fleetspace | ||
| Account. | ||
| :vartype resource_id: str | ||
| :ivar arm_location: The location of global database account in the Fleetspace Account. |
Copilot
AI
May 21, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There's an extra space between 'of' and 'global'. Please remove the double space for consistency.
| :ivar arm_location: The location of global database account in the Fleetspace Account. | |
| :ivar arm_location: The location of global database account in the Fleetspace Account. |
|
Hi @pjohari-ms Release SuggestionsModule: cosmosdb-preview
Notes
|
This checklist is used to make sure that common guidelines for a pull request are followed.
Related command
General Guidelines
azdev style <YOUR_EXT>locally? (pip install azdevrequired)python scripts/ci/test_index.py -qlocally? (pip install wheel==0.30.0required)For new extensions:
About Extension Publish
There is a pipeline to automatically build, upload and publish extension wheels.
Once your pull request is merged into main branch, a new pull request will be created to update
src/index.jsonautomatically.You only need to update the version information in file setup.py and historical information in file HISTORY.rst in your PR but do not modify
src/index.json.